Pull #18253: infra: Fixing ECJ's version to be pinned, rather than being dynamic to not break CI pipelines#18253
Conversation
942f3b6 to
2266265
Compare
|
Thanks a lot for helping. |
fb4efa6 to
ebafe1e
Compare
|
Thanks a lot for help. Please apply https://github.com/checkstyle/checkstyle/wiki/How-to-run-certain-phases-and-validations#how-to-create-commit-that-skips-all-ci |
|
Thanks for pointing that out, sorry for not isolating just semaphore CI test. |
970d54a to
e1a4acb
Compare
|
Thank you so much for being patient with me while I was burning CI credits. do I need to re run in order to pass the Internal Server Error (500) error: Pitest / test (api) (pull_request)? can you please re run it so it passes? SolutionAs of now, I've pinned the version of Eclipse to |
|
This is not a fix for issue to use latest eclipse static analysis, but it is workaround to stop using latest from web and use what is already in our artifacts cache. Please put in commit message reference to this PR , "Pull #18253: ....". We will merge this PR as workaround, and we will change issue to be for migration to new eclipse version |
|
Thanks for replying, I'll make all the changes as requested. I must have missed them. Though I'm curious about the long-term strategy here, I want to understand properly. If we revert to a dynamic version in the future, doesn't that leave the CI pipeline vulnerable to breaking again whenever a new update is released? (sort of like this instance?) Or is the goal to intentionally break early so we can ensure CheckStyle always adheres to the latest static analysis standards, rather than accumulating onto an older version? |
a42d854 to
faf5343
Compare
…er than being dynamic to not break CI pipelines
It was was that fragile. |
Issue #18251
Just added
org.eclipse.jdt.core.compiler.problem.memberOfDeprecatedTypeNotDeprecated=ignoreontoconfig/org.eclipse.jdt.core.prefs