Why do we need to check for \n, \r ?

to avoid false positive on empty comment, i think.

@mohitsatr can you investigate it? If it is missing such empty comments cases then please add them

for /n', it is empty comments//. they are already in inputs.
I’m not entirely sure about /r, but since it’s already in our codebase, I assume it has been thoroughly tested and is there for a reason.

Can you try to remove \r from checkstyle-checks.xml and run mvn clean verify locally? If build fails then we will be able to find test cases for it, add them to google Inputs

I first removed and not(@text = '\r') and ran the built, then I also removed and not(@text = '\r\n') and built. no errors on both builts.

wait! I use Linux, so it'd build successfully anyway right ?

I'd try it. I use window ( I'm noob 🫠 )

tested it and build doesn't fail.

Config:

    <module name="MatchXpath">
      <property name="id" value="singleLineCommentStartWithSpace"/>
      <property name="query"
                value="//SINGLE_LINE_COMMENT[./COMMENT_CONTENT[not(starts-with(@text, ' '))
                       and not(starts-with(@text, '/'))
                       and not(@text = '\n') and not(ends-with(@text, '//\n'))]]"/>
      <message key="matchxpath.match" value="''//'' must be followed by a whitespace."/>
    </module>

tried changing both configs: google_checks.xml and checkstyle-checks.xml and build was still passing.

For now we can change it in google-config. I will send the changes after #17264

we should document usage of it, it is validation module that should be in coverage table.

can you provide an example for how to do this ?

He's suggesting to add MatchXpath to the coverage, in the rule for which it is used and maybe also explain how it is used.

It should be referenced in table of coverage on a line that requires it.

done.

@mohitsatr, I still see this removal in PR

removed.