Skip to content

supplemental: add space between '//' and 'non-compiled' comments#17264

Merged
romani merged 1 commit into
checkstyle:masterfrom
mohitsatr:validation-with-a-space
Jun 26, 2025
Merged

supplemental: add space between '//' and 'non-compiled' comments#17264
romani merged 1 commit into
checkstyle:masterfrom
mohitsatr:validation-with-a-space

Conversation

@mohitsatr

Copy link
Copy Markdown
Member

part of #17193

@romani

romani commented Jun 23, 2025

Copy link
Copy Markdown
Member

@AmitKumarDeoghoria , did we remove jdk11 compilation? We supposed to substitute it with Jdk17

@romani

romani commented Jun 23, 2025

Copy link
Copy Markdown
Member

@mohitsatr , please investigate ci failure

@mohitsatr

Copy link
Copy Markdown
Member Author

I don't understand what this error is about ?

src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/asttreestringprinter/InputAstTreeStringPrinter.java:2: error: class, interface, enum, or record expected
classD a {}
^

the file InputAstTreeStringPrinter.java does not exist in codebase.

@romani

romani commented Jun 23, 2025

Copy link
Copy Markdown
Member

https://github.com/checkstyle/checkstyle/blob/master/src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/asttreestringprinter/InputAstTreeStringPrinter.java

Something is damaged in selection of files for compilation, please investigate shell job that doing it.

@mohitsatr mohitsatr force-pushed the validation-with-a-space branch 2 times, most recently from 1a3fe8f to 37640a1 Compare June 24, 2025 05:50
@mohitsatr

mohitsatr commented Jun 24, 2025

Copy link
Copy Markdown
Member Author

@romani do we handle //non-compilable by eclipse any differently?

on running ./.ci/validation.sh javac11 I'm getting the following error

src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/onestatementperline/InputOneStatementPerLine.java:22: error: extraneous semicolon
; // non-compilable by eclipse

@romani

romani commented Jun 24, 2025

Copy link
Copy Markdown
Member

handle //non-compilable by eclipse any differently?

It is just another non-compiled source file. It is not compiled by Eclipse not a javac, so to avoid problems to Eclipse users, we put it non-compiled. Should continue to be there.

Lets chat regexp to // non-compiled with to allow any reasons of compilation problems

@mohitsatr mohitsatr force-pushed the validation-with-a-space branch 2 times, most recently from 6e2c0e4 to 81e3cfd Compare June 25, 2025 14:21
@mohitsatr

Copy link
Copy Markdown
Member Author

weird, javac11 workflow in passing in my local. but it keeps a missed case everytime I push.

@mohitsatr mohitsatr force-pushed the validation-with-a-space branch from 81e3cfd to 03b677c Compare June 25, 2025 15:05

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !!!!

@romani romani merged commit 781094d into checkstyle:master Jun 26, 2025
119 checks passed
@romani

romani commented Jun 26, 2025

Copy link
Copy Markdown
Member

@Zopsss , FYI

I merged quickly as update was huge, to avoid conflicts with Jdk17 project activity.

@mohitsatr mohitsatr deleted the validation-with-a-space branch June 26, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants