minor: remove token from ignore list that are present in google config#14292
Merged
Conversation
nrmancuso
suggested changes
Jan 18, 2024
Comment on lines
237
to
238
| // non text literals are ignored | ||
| "NUM_DOUBLE", "NUM_FLOAT", "NUM_INT", "NUM_LONG", "IDENT", |
Contributor
There was a problem hiding this comment.
Suggested change
| // non text literals are ignored | |
| "NUM_DOUBLE", "NUM_FLOAT", "NUM_INT", "NUM_LONG", "IDENT", | |
| // numerical types should not be included | |
| "NUM_DOUBLE", "NUM_FLOAT", "NUM_INT", "NUM_LONG", | |
| // identitifiers are covered by other checks | |
| "IDENT", |
| // comments should be skipped as nobody write in octal or unicode code style | ||
| "COMMENT_CONTENT", | ||
| // until #14291 | ||
| "TEXT_BLOCK_CONTENT") |
Contributor
There was a problem hiding this comment.
Please wrap ) to reduce future diff.
2cdae62 to
2880596
Compare
nrmancuso
approved these changes
Jan 31, 2024
2880596 to
0f4f29d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detected at #13991 (comment)
to be merged after #13991