Issue #13830: Support Java 21 string template syntax by nrmancuso · Pull Request #13991 · checkstyle/checkstyle

nrmancuso · 2023-11-03T04:43:28Z

New grammar summary (from here):

TemplateExpression:
    TemplateProcessor . TemplateArgument

TemplateProcessor:
    Expression

TemplateArgument:
    Template
    StringLiteral
    TextBlock

Template:
    StringTemplate
    TextBlockTemplate

StringTemplate:
    StringTemplateBegin EmbeddedExpression
      { StringTemplateMid EmbeddedExpression } StringTemplateEnd

TextBlockTemplate:
    TextBlockTemplateBegin EmbeddedExpression
      { TextBlockTemplateMid EmbeddedExpression } TextBlockTemplateEnd

EmbeddedExpression:
    [ Expression ]

Reading:

Attention: mutliline strings delimited with only single " are possible.

Link to reports: nrmancuso/nrmancuso.github.io#56 (comment)

Diff Regression projects: https://raw.githubusercontent.com/checkstyle/contribution/d1348582c72049059c64d46601ce6aaca45baae2/checkstyle-tester/projects-to-test-on-for-github-action.properties

Diff Regression config: https://gist.githubusercontent.com/nrmancuso/4e014025168093baa3f61986a32a96b7/raw/294f634d72297b7b318de79788ca2b153ab33bd2/base_config.xml

Diff Regression patch config: https://gist.githubusercontent.com/nrmancuso/fa9d105fd211d31124cb852aaac54f73/raw/fc90a8f543660dca8ea8acb4afe03e3eee75c76e/patch_config.xml

Projects file: projects-to-test-on.properties
Patch branch: issue-13830

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/sevntu-check-regression_part_1/index.html

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/part4/index.html

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/part1/index.html

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/part5/index.html

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/sevntu-check-regression_part_2/index.html

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/part6/index.html

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/part2/index.html

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/part3/index.html

https://checkstyle-reports.s3.us-east-2.amazonaws.com/reports/issue-13830/2023-12-28-T-16-11-57/antlr-report/index.html

All differences are either new violations in files that we were not able to parse previously, or change in exception lines in noncompilable code.

nrmancuso

I am starting with String templates (as opposed to text block templates), here are some examples:

nrmancuso · 2023-11-03T04:48:27Z

+    int y = 20;
+
+    // most basic example, empty string template expression
+    String result1 = STR."";


I suppose it is still a template, we should do https://github.com/checkstyle/checkstyle/pull/13991/files#r1421784134, I will update the code.

| |--ASSIGN -> = [9:19] | | `--EXPR -> EXPR [9:24] | | `--DOT -> . [9:24] | | |--IDENT -> STR [9:21] | | `--STRING_LITERAL -> "" [9:25]

is consistent with what we do now.

| | `--DOT -> . [15:24] | | |--IDENT -> STR [15:21] | | `--STRING_TEMPLATE_BEGIN -> " | | |--STRING_TEMPLATE_CONTENT -> | | `--STRING_TEMPLATE_END -> "

is to clear pointer it is String Template syntax.

if we reuse old tree, we might immediately need to update all our Checks to exclude this from consideration. and it will be hard to find by AST that it is String Template.

I vote for STRING_TEMPLATE_BEGIN approach.

nrmancuso · 2023-11-03T04:48:49Z

+    String result1 = STR."";
+
+    // simple single value interpolation
+    String result2 = STR. "x\{ x }x";


|--VARIABLE_DEF -> VARIABLE_DEF [12:4] | |--MODIFIERS -> MODIFIERS [12:4] | |--TYPE -> TYPE [12:4] | | `--IDENT -> String [12:4] | |--IDENT -> result2 [12:11] | |--ASSIGN -> = [12:19] | | `--EXPR -> EXPR [12:24] | | `--DOT -> . [12:24] | | |--IDENT -> STR [12:21] | | `--STRING_TEMPLATE_BEGIN -> "x\{ [12:26] | | |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [12:31] | | | `--IDENT -> x [12:31] | | `--STRING_TEMPLATE_END -> }x" [12:33] | `--SEMI -> ; [12:36]

Need to add a case with no embedded expression (like no x here)

in my imagination, it bit more trrucrured:

`--STRING_TEMPLATE_BEGIN -> " [12:26] |--TEMPLATE_CONTENT -> x |--EMBEDED_BEGIN -> "\{ |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [12:31] | |--IDENT -> x [12:31] |--EMBEDED_END -> } |--TEMPLATE_CONTENT -> x [12:33] `--STRING_TEMPLATE_END -> " [12:33]

proposed tree is not strict, just hint to have TEMPLATE_CONTENT and EMBEDED_BEGIN/END

I also prefer your proposal, however this will be a bit more challenging to create. Let me see what I can do. However, the current implementation is more reflective of the actual java grammar.

Ok:

STRING_TEMPLATE_BEGIN -> " [12:26] |--STRING_TEMPLATE_CONTENT -> x [12:27] |--EMBEDDED_EXPRESSION_BEGIN -> \{ [12:28] |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [12:31] | `--IDENT -> x [12:31] |--EMBEDDED_EXPRESSION_END -> } [12:33] |--STRING_TEMPLATE_CONTENT -> x [12:34] `--STRING_TEMPLATE_END -> " [12:35]

Looks good.

All other examples have been edited, this is the new AST for this code (it has moved down in the source code file):

|--VARIABLE_DEF -> VARIABLE_DEF [15:4] | |--MODIFIERS -> MODIFIERS [15:4] | |--TYPE -> TYPE [15:4] | | `--IDENT -> String [15:4] | |--IDENT -> result2 [15:11] | |--ASSIGN -> = [15:19] | | `--EXPR -> EXPR [15:24] | | `--DOT -> . [15:24] | | |--IDENT -> STR [15:21] | | `--STRING_TEMPLATE_BEGIN -> " [15:26] | | |--STRING_TEMPLATE_CONTENT -> x [15:27] | | |--EMBEDDED_EXPRESSION_BEGIN -> \{ [15:28] | | |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [15:31] | | | `--IDENT -> x [15:31] | | |--EMBEDDED_EXPRESSION_END -> } [15:33] | | |--STRING_TEMPLATE_CONTENT -> x [15:34] | | `--STRING_TEMPLATE_END -> " [15:35] | `--SEMI -> ; [15:36]

nrmancuso · 2023-11-03T04:49:22Z

+    String result2 = STR. "x\{ x }x";
+
+    // simple single value interpolation with a method call
+    String result3 = STR. "\{ y(y("y")) }";


|--VARIABLE_DEF -> VARIABLE_DEF [18:4] | |--MODIFIERS -> MODIFIERS [18:4] | |--TYPE -> TYPE [18:4] | | `--IDENT -> String [18:4] | |--IDENT -> result3 [18:11] | |--ASSIGN -> = [18:19] | | `--EXPR -> EXPR [18:24] | | `--DOT -> . [18:24] | | |--IDENT -> STR [18:21] | | `--STRING_TEMPLATE_BEGIN -> " [18:26] | | |--STRING_TEMPLATE_CONTENT -> [18:27] | | |--EMBEDDED_EXPRESSION_BEGIN -> \{ [18:27] | | |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [18:31] | | | `--METHOD_CALL -> ( [18:31] | | | |--IDENT -> y [18:30] | | | |--ELIST -> ELIST [18:33] | | | | `--EXPR -> EXPR [18:33] | | | | `--METHOD_CALL -> ( [18:33] | | | | |--IDENT -> y [18:32] | | | | |--ELIST -> ELIST [18:34] | | | | | `--EXPR -> EXPR [18:34] | | | | | `--STRING_LITERAL -> "y" [18:34] | | | | `--RPAREN -> ) [18:37] | | | `--RPAREN -> ) [18:38] | | |--EMBEDDED_EXPRESSION_END -> } [18:40] | | |--STRING_TEMPLATE_CONTENT -> [18:41] | | `--STRING_TEMPLATE_END -> " [18:41] | `--SEMI -> ; [18:42]

nrmancuso · 2023-11-03T04:49:52Z

+    String result3 = STR. "\{ y(y("y")) }";
+
+    // bit more complex example, multiple interpolations
+    String result4 = STR. "\{ x }"  + STR. "\{ y }";


|--VARIABLE_DEF -> VARIABLE_DEF [21:4] | |--MODIFIERS -> MODIFIERS [21:4] | |--TYPE -> TYPE [21:4] | | `--IDENT -> String [21:4] | |--IDENT -> result4 [21:11] | |--ASSIGN -> = [21:19] | | `--EXPR -> EXPR [21:36] | | `--PLUS -> + [21:36] | | |--DOT -> . [21:24] | | | |--IDENT -> STR [21:21] | | | `--STRING_TEMPLATE_BEGIN -> " [21:26] | | | |--STRING_TEMPLATE_CONTENT -> [21:27] | | | |--EMBEDDED_EXPRESSION_BEGIN -> \{ [21:27] | | | |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [21:30] | | | | `--IDENT -> x [21:30] | | | |--EMBEDDED_EXPRESSION_END -> } [21:32] | | | |--STRING_TEMPLATE_CONTENT -> [21:33] | | | `--STRING_TEMPLATE_END -> " [21:33] | | `--DOT -> . [21:41] | | |--IDENT -> STR [21:38] | | `--STRING_TEMPLATE_BEGIN -> " [21:43] | | |--STRING_TEMPLATE_CONTENT -> [21:44] | | |--EMBEDDED_EXPRESSION_BEGIN -> \{ [21:44] | | |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [21:47] | | | `--IDENT -> y [21:47] | | |--EMBEDDED_EXPRESSION_END -> } [21:49] | | |--STRING_TEMPLATE_CONTENT -> [21:50] | | `--STRING_TEMPLATE_END -> " [21:50] | `--SEMI -> ; [21:51]

nrmancuso · 2023-11-03T04:50:46Z

+    String result10 = STR. "hey \{
+            y(y("y")) + y(y("y"))
+            } there \{
+            y(y("y")) + y(y("y"))
+            + STR."x\{ x }x"
+            }";


|--VARIABLE_DEF -> VARIABLE_DEF [41:4] | |--MODIFIERS -> MODIFIERS [41:4] | |--TYPE -> TYPE [41:4] | | `--IDENT -> String [41:4] | |--IDENT -> result10 [41:11] | |--ASSIGN -> = [41:20] | | `--EXPR -> EXPR [41:25] | | `--DOT -> . [41:25] | | |--IDENT -> STR [41:22] | | `--STRING_TEMPLATE_BEGIN -> " [41:27] | | |--STRING_TEMPLATE_CONTENT -> hey [41:28] | | |--EMBEDDED_EXPRESSION_BEGIN -> \{ [41:32] | | |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [42:22] | | | `--PLUS -> + [42:22] | | | |--METHOD_CALL -> ( [42:13] | | | | |--IDENT -> y [42:12] | | | | |--ELIST -> ELIST [42:15] | | | | | `--EXPR -> EXPR [42:15] | | | | | `--METHOD_CALL -> ( [42:15] | | | | | |--IDENT -> y [42:14] | | | | | |--ELIST -> ELIST [42:16] | | | | | | `--EXPR -> EXPR [42:16] | | | | | | `--STRING_LITERAL -> "y" [42:16] | | | | | `--RPAREN -> ) [42:19] | | | | `--RPAREN -> ) [42:20] | | | `--METHOD_CALL -> ( [42:25] | | | |--IDENT -> y [42:24] | | | |--ELIST -> ELIST [42:27] | | | | `--EXPR -> EXPR [42:27] | | | | `--METHOD_CALL -> ( [42:27] | | | | |--IDENT -> y [42:26] | | | | |--ELIST -> ELIST [42:28] | | | | | `--EXPR -> EXPR [42:28] | | | | | `--STRING_LITERAL -> "y" [42:28] | | | | `--RPAREN -> ) [42:31] | | | `--RPAREN -> ) [42:32] | | |--EMBEDDED_EXPRESSION_END -> } [43:12] | | |--STRING_TEMPLATE_CONTENT -> there [43:13] | | |--EMBEDDED_EXPRESSION_BEGIN -> \{ [43:20] | | |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [45:12] | | | `--PLUS -> + [45:12] | | | |--PLUS -> + [44:22] | | | | |--METHOD_CALL -> ( [44:13] | | | | | |--IDENT -> y [44:12] | | | | | |--ELIST -> ELIST [44:15] | | | | | | `--EXPR -> EXPR [44:15] | | | | | | `--METHOD_CALL -> ( [44:15] | | | | | | |--IDENT -> y [44:14] | | | | | | |--ELIST -> ELIST [44:16] | | | | | | | `--EXPR -> EXPR [44:16] | | | | | | | `--STRING_LITERAL -> "y" [44:16] | | | | | | `--RPAREN -> ) [44:19] | | | | | `--RPAREN -> ) [44:20] | | | | `--METHOD_CALL -> ( [44:25] | | | | |--IDENT -> y [44:24] | | | | |--ELIST -> ELIST [44:27] | | | | | `--EXPR -> EXPR [44:27] | | | | | `--METHOD_CALL -> ( [44:27] | | | | | |--IDENT -> y [44:26] | | | | | |--ELIST -> ELIST [44:28] | | | | | | `--EXPR -> EXPR [44:28] | | | | | | `--STRING_LITERAL -> "y" [44:28] | | | | | `--RPAREN -> ) [44:31] | | | | `--RPAREN -> ) [44:32] | | | `--DOT -> . [45:17] | | | |--IDENT -> STR [45:14] | | | `--STRING_TEMPLATE_BEGIN -> " [45:18] | | | |--STRING_TEMPLATE_CONTENT -> x [45:19] | | | |--EMBEDDED_EXPRESSION_BEGIN -> \{ [45:20] | | | |--EMBEDDED_EXPRESSION -> EMBEDDED_EXPRESSION [45:23] | | | | `--IDENT -> x [45:23] | | | |--EMBEDDED_EXPRESSION_END -> } [45:25] | | | |--STRING_TEMPLATE_CONTENT -> x [45:26] | | | `--STRING_TEMPLATE_END -> " [45:27] | | |--EMBEDDED_EXPRESSION_END -> } [46:12] | | |--STRING_TEMPLATE_CONTENT -> [46:13] | | `--STRING_TEMPLATE_END -> " [46:13] | `--SEMI -> ; [46:14]

nrmancuso · 2023-11-03T12:56:14Z

Need to add Java 21 compilation job to CI

nandorholozsnyak · 2023-11-23T07:50:42Z

Hello there,
What is the status of this PR? I'm curious about the release :)

nrmancuso · 2023-11-25T15:09:48Z

Hello there, What is the status of this PR? I'm curious about the release :)

Hi @nandorholozsnyak , grammar changes are rarely trivial, and require quite a bit of maintainer time. We can certainly cut a release as soon as this is merged if you would like, we do not need to wait for normal release cycle.

nandorholozsnyak · 2023-11-25T16:02:35Z

Hello there, What is the status of this PR? I'm curious about the release :)

Hi @nandorholozsnyak , grammar changes are rarely trivial, and require quite a bit of maintainer time. We can certainly cut a release as soon as this is merged if you would like, we do not need to wait for normal release cycle.

Hello,
I'm not familiar with your release cycle, I'm not pushing it to be released, but I guess there can be other projects where it can be a blocker of the String template usage.

Take your time and make sure it works properly :)

romani · 2023-11-25T17:47:00Z

@nandorholozsnyak , if you have time to contribute, please help us with #12542 , and people will not be blocked by new grammar usage any more .

Main point of PR to be merged, release can be done at any time, to ship to users sooner.

nandorholozsnyak · 2023-11-25T20:39:30Z

@nandorholozsnyak , if you have time to contribute, please help us with #12542 , and people will not be blocked by new grammar usage any more .

Main point of PR to be merged, release can be done at any time, to ship to users sooner.

Hey @romani
Thank you, I'll take a look on it. :)

github-actions · 2023-12-10T22:44:46Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/046a790_2023224414/reports/diff/index.html

romani · 2023-12-28T03:57:39Z

Need to add Java 21 compilation job to CI

Let's move it to separate PR and merge sooner. I saw somewhere another PR that try to do same.

romani · 2024-01-11T04:53:04Z

why two commits with same message?

nrmancuso · 2024-01-11T13:08:46Z

why two commits with same message?

This was a mistake, fixed.

romani · 2024-01-11T14:30:40Z

Checker is not green.

rnveach · 2024-01-11T17:48:04Z

@nrmancuso I'll look over again soon, but I saw no response to my comment at #13991 (comment) .

nrmancuso · 2024-01-12T01:00:39Z

@nrmancuso I'll look over again soon, but I saw no response to my comment at #13991 (comment) .

I can create an issue for this; in the past we have only fixed NPEs in grammar updates

romani

items:

romani · 2024-01-18T02:56:17Z

                "NUM_DOUBLE", "NUM_FLOAT", "NUM_INT", "NUM_LONG", "IDENT",
-                "COMMENT_CONTENT", "STRING_LITERAL", "CHAR_LITERAL", "TEXT_BLOCK_CONTENT")
+                "COMMENT_CONTENT", "STRING_LITERAL", "CHAR_LITERAL", "TEXT_BLOCK_CONTENT",
+                "STRING_TEMPLATE_CONTENT")


This update is strange.
https://checkstyle.org/styleguides/google-java-style-20180523/javaguide.html#s2.3.2-special-escape-sequences
https://checkstyle.org/google_style.html#a2.3.2

checkstyle/src/main/resources/google_checks.xml

Line 54 in 2534302

<property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>

Why we ignoring such tokens, as they can have content that we need to validate ?

We can definitely improve this in separate issue, just curious

I do not remember reasoning, but we have added all new syntax to this collection. Maybe it was due to not being explicitly mentioned in Googles style guide.

Issue created at #14291

romani

last items: 2 examples in tokens javadoc , not a single for all

romani · 2024-01-18T14:25:41Z

+     * at the beginning of a string template.
+     * <p>For example:</p>
+     * <pre>
+     *     String s = STR."Hello, \{name}!";


String s = STR."Hello, \{firstName + lastName}!";

romani · 2024-01-18T14:25:48Z

+     * at the end of a string template.
+     * <p>For example:</p>
+     * <pre>
+     *     String s = STR."Hello, \{name}!";


String s = STR."Hello, \{firstName + lastName}!";

romani · 2024-01-18T14:27:04Z

+     * An expression embedded within a string template.
+     * <p>For example:</p>
+     * <pre>
+     *     String s = STR."Hello, \{name}!";


String s = STR."Hello, \{getName("Mr. ")}!";

romani · 2024-01-18T14:27:11Z

+     * template.
+     * <p>For example:</p>
+     * <pre>
+     *     String s = STR."Hello, \{name}!";


String s = STR."Hello, \{getName("Mr. ")}!";

Changed these a bit to reuse the firstName, lastName concept but with a method call as suggested.

romani · 2024-01-18T14:27:31Z

+     * template may have more than one node of this type.
+     * <p>For example:</p>
+     * <pre>
+     *     String s = STR."Hello, \{name}!";


String s = STR."Hello, \{firstName + lastName}!";

romani · 2024-01-18T14:27:57Z

+     * The opening delimiter of an embedded expression within a string template.
+     * <p>For example:</p>
+     * <pre>
+     *     String s = STR."Hello, \{name}!";


String s = STR."Hello, \{getName("Mr. ")}!";

…CONTENT

NoSugarCoffee · 2024-08-08T13:47:03Z

@nrmancuso Is there any news for the text block template?

String name    = "Joan Smith";
String phone   = "555-123-4567";
String address = "1 Maple Drive, Anytown";
String json = STR."""
    {
        "name":    "\{name}",
        "phone":   "\{phone}",
        "address": "\{address}"
    }
    """;

nrmancuso · 2024-08-10T12:38:42Z

@NoSugarCoffee news is here: #14805

NoSugarCoffee · 2024-08-10T13:04:03Z

@nrmancuso It is clear and make sense，thanks

nrmancuso commented Nov 3, 2023

View reviewed changes

nrmancuso requested review from rnveach and romani November 3, 2023 15:31

romani assigned romani and nrmancuso and unassigned romani Nov 12, 2023

nrmancuso force-pushed the issue-13830 branch 5 times, most recently from d642cb9 to c0ed0ef Compare December 10, 2023 16:51

nrmancuso commented Dec 10, 2023

View reviewed changes

Comment thread src/xdocs/checks/coding/illegaltokentext.xml

nrmancuso force-pushed the issue-13830 branch from c0ed0ef to 046a790 Compare December 10, 2023 18:41

checkstyle deleted a comment from github-actions Bot Dec 10, 2023

nrmancuso force-pushed the issue-13830 branch from 046a790 to 823886a Compare December 11, 2023 02:26

nrmancuso force-pushed the issue-13830 branch 5 times, most recently from 9079ffe to a8faca4 Compare December 28, 2023 03:48

nrmancuso force-pushed the issue-13830 branch 2 times, most recently from 4c028d0 to 5de63cc Compare December 28, 2023 05:02

nrmancuso force-pushed the issue-13830 branch 2 times, most recently from 93d5480 to 3319a62 Compare January 11, 2024 04:47

nrmancuso force-pushed the issue-13830 branch from 3319a62 to fcb2410 Compare January 11, 2024 13:08

nrmancuso force-pushed the issue-13830 branch from fcb2410 to 7600cf0 Compare January 14, 2024 21:41

romani mentioned this pull request Jan 15, 2024

Support Java 21 string template syntax #13830

Closed

rnveach approved these changes Jan 16, 2024

View reviewed changes

rnveach assigned romani and unassigned rnveach Jan 16, 2024

romani requested changes Jan 17, 2024

View reviewed changes

nrmancuso force-pushed the issue-13830 branch from 7600cf0 to dbc54ca Compare January 18, 2024 02:33

romani reviewed Jan 18, 2024

View reviewed changes

nrmancuso mentioned this pull request Jan 18, 2024

Escape sequences in TextBlock, IllegalTokenText module should violate them for Google style #14291

Closed

romani mentioned this pull request Jan 18, 2024

minor: remove token from ignore list that are present in google config #14292

Merged

romani requested changes Jan 18, 2024

View reviewed changes

nrmancuso added 3 commits January 19, 2024 08:17

minor: Arrays.asList -> List.of

63a1b80

Issue checkstyle#13830: Add support for Java 21 string templates

2b870e2

Issue checkstyle#14289: IllegalTokenText support for STRING_TEMPLATE_…

8cfb314

…CONTENT

nrmancuso force-pushed the issue-13830 branch from dbc54ca to 8cfb314 Compare January 19, 2024 13:17

romani merged commit 3e07018 into checkstyle:master Jan 19, 2024

romani mentioned this pull request Jan 20, 2024

upadat example in javadoc for EMBEDDED_EXPRESSION* tokens #14317

Closed

nrmancuso deleted the issue-13830 branch August 10, 2024 12:38

PawanTheGod mentioned this pull request Mar 22, 2026

Update AST Javadoc examples and add @since for TokenTypes #19376

Open

Uh oh!

Conversation

nrmancuso commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nrmancuso left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrmancuso Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrmancuso Dec 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romani Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrmancuso Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrmancuso Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrmancuso Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrmancuso commented Nov 3, 2023

Uh oh!

nandorholozsnyak commented Nov 23, 2023

Uh oh!

nrmancuso commented Nov 25, 2023

Uh oh!

nandorholozsnyak commented Nov 25, 2023

Uh oh!

romani commented Nov 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nandorholozsnyak commented Nov 25, 2023

Uh oh!

Uh oh!

github-actions Bot commented Dec 10, 2023

Uh oh!

romani commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani commented Jan 11, 2024

Uh oh!

nrmancuso commented Jan 11, 2024

Uh oh!

romani commented Jan 11, 2024

Uh oh!

rnveach commented Jan 11, 2024

Uh oh!

nrmancuso commented Jan 12, 2024

Uh oh!

romani left a comment

Choose a reason for hiding this comment

nrmancuso commented Nov 3, 2023 •

edited

Loading

nrmancuso left a comment •

edited

Loading

nrmancuso Nov 3, 2023 •

edited

Loading

nrmancuso Dec 10, 2023 •

edited

Loading

romani Nov 13, 2023 •

edited

Loading

nrmancuso Nov 3, 2023 •

edited

Loading

nrmancuso Nov 3, 2023 •

edited

Loading

nrmancuso Nov 3, 2023 •

edited

Loading

romani commented Nov 25, 2023 •

edited

Loading

romani commented Dec 28, 2023 •

edited

Loading

romani left a comment •

edited

Loading

nrmancuso Jan 19, 2024 •

edited

Loading