Issue #13328: kill mutations in MatchXpathCheck#13726
Merged
romani merged 1 commit intocheckstyle:masterfrom Sep 11, 2023
Merged
Issue #13328: kill mutations in MatchXpathCheck#13726romani merged 1 commit intocheckstyle:masterfrom
romani merged 1 commit intocheckstyle:masterfrom
Conversation
e6841a2 to
9337fe9
Compare
9337fe9 to
0e0b886
Compare
Member
Author
|
Github, generate report |
rdiachenko
commented
Sep 10, 2023
| @Override | ||
| public void beginTree(DetailAST rootAST) { | ||
| if (xpathExpression != null) { | ||
| if (!query.isEmpty()) { |
Member
Author
There was a problem hiding this comment.
xpathExpression depends on query, if query is not empty the xpathExpression is set in setQuery and is guaranteed to be not null.
Updating this condition allows to use default value for query with pitest mutation killed.
romani
approved these changes
Sep 10, 2023
Member
romani
left a comment
There was a problem hiding this comment.
Ok to merge.
Regression report is not required.
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13328
Attempt to improve this PR: #13242