It's a copy paste of testEvaluationException() with exception checked. It should be possible to test it via input like:

/*
MatchXpath
query = count(*) div 0

*/

package com.puppycrawl.tools.checkstyle.checks.coding.matchxpath;

public class InputWithBadQuery {
}

Yes, no new pure unit testing in fake tree.
All should be on our AST and on our Check.

It should be possible to test it via input like:

Yes, but we want to get the exact message of the exception
it won't work with input based
please guide me if I miss anything

    @Test
    public void testCheckWithMatchingMethodName2() throws Exception {
        final DefaultConfiguration checkConfig = createModuleConfig(MatchXpathCheck.class);
        checkConfig.addProperty("query", "count(*) div 0");
        try {
           verify(checkConfig, getPath("InputMatchXpath5.java"));
        }
        catch (XPathException ex) {
            assertWithMessage("Exception message")
                .that(ex.getMessage())
                .isEqualTo("Evaluation of Xpath query failed: count(*) div 0");
        }
    }

Input file is as same as mentioned at #13242 (comment)

Did you try to catch all exceptions ? I think there should be CheckstyleException
And message will be in cause exception.

If you tried and it didn't not, please show all all details on how you did this and what is results

Done please check

Thanks

somthing is broken in this Check.

if user did setQuery ones he can not return Check to default state by setting setQuery("") by providing default value.
it is not possible to set query twice in our config, but plugings (sonar, eclipse-cs) are working directly with modules (no xml), so it might be problem for them.

I am ok with pure junit here , but we need to have default and we need to restore Check instance to default mode of execution by setting defalt value in its setter.

And we need to reset xpathExpression field if user set empty value.
Empty string should mean null in xpathExpression

No issue I will look on this by tommorow

@Kevin222004 any update on this?

@rdiachenko sorry I haven't visited it yet will update as soon as possible

@romani I haven't missed #13242 (comment) this but,
please look at the updated pr. I have make a slight change in setter. I don't think it is required to restore check instance.
I added all the kind of test #13242 (comment) please check

Having null as default, make it impossible to set back to default.
There is no null as value in xml

What I meant is to update setter to:

if (!query.isEmpty()) {
....
} else {
this.query = "";
this.xpathExpression = null;
}

Not sure I'm following the request with null. @Kevin222004 what's the latest status of this PR?

We should remove such field, having this.xpathExpression is enough.
We have no functionality to reuse what user set, so we can loose it for now.

@Kevin222004 , what is problem to remove this field