Issue #13109: Kill mutation for MagicNumber#13196
Merged
romani merged 1 commit intocheckstyle:masterfrom Jun 14, 2023
Merged
Conversation
Contributor
Author
|
Github, generate report |
Contributor
Contributor
Author
|
Github, generate report |
Contributor
Contributor
Author
|
@romani in semaphore eclipse static analysis in failing in all pr and not even loading the page |
Member
|
Semaphore failure is same as in master branch. Ply ignore it for some time. Please proceed with explanation of mutation killing. |
Member
|
Please keep links to such PRs in our issue for bad side effects of pitest, to have all examples at one place. |
rdiachenko
approved these changes
Jun 12, 2023
Member
rdiachenko
left a comment
There was a problem hiding this comment.
lgtm
@romani there is a semaphore failure, what causes it do you know?
Contributor
Author
|
@rdiachenko If you re run it will be resolved the pr for resolving it has been merged |
Member
|
Semaphore was resolved by #13201 All affected PRs must be rebased to avoid such problems. |
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13109: Kill mutation for MagicNumber
Check :-
https://checkstyle.org/config_coding.html#MagicNumber
Mutation Covered
checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml
Lines 93 to 100 in eaed451
Explaination :-
if we remove .getParent no issue will their because in loop it will be update by
currentAST = currentAST.getParent();so the loops run one timr more.Regression
Diff Regression config: https://gist.githubusercontent.com/Kevin222004/6c454ec1c672a21710fc0cda01ceaf5b/raw/3fc36498aa1511c61c41cefb46ff02cdf8a1d2bb/magic.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Report-2