Skip to content

infra: update jdk for eclipse static analysis#13201

Merged
romani merged 1 commit intocheckstyle:masterfrom
nrmancuso:fix-eclipse
Jun 13, 2023
Merged

infra: update jdk for eclipse static analysis#13201
romani merged 1 commit intocheckstyle:masterfrom
nrmancuso:fix-eclipse

Conversation

@nrmancuso
Copy link
Copy Markdown
Contributor

@nrmancuso nrmancuso commented Jun 11, 2023

Noticed at https://checkstyle.semaphoreci.com/jobs/a2f1d5ba-6547-45a8-a9b1-fc00c7f7c49c, we need to update jdk for this job to 17 (major ver. 61)

@nrmancuso
Copy link
Copy Markdown
Contributor Author

nrmancuso commented Jun 11, 2023

Link to semaphore execution: https://checkstyle.semaphoreci.com/workflows/4815f09c-12df-48d6-b0f3-40ebcf838836?pipeline_id=df083745-bd5d-42f0-87c6-ad29e6df5241

Latest eclipse release is R-4.28-202306050440

@rnveach
Copy link
Copy Markdown
Contributor

rnveach commented Jun 11, 2023

https://checkstyle.semaphoreci.com/jobs/03067066-250a-4b0a-9518-ee586b8b65d5

15. ERROR in /home/semaphore/checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/MainTest.java (at line 869) 00:22
	fileMock, new ArrayList<Pattern>()); 00:22
	              ^^^^^^^^^ 00:22
Redundant specification of type arguments <Pattern> 00:22
---------- 00:22
16. ERROR in /home/semaphore/checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/MainTest.java (at line 905) 00:22
	fileMock, new ArrayList<Pattern>()); 00:22
	              ^^^^^^^^^ 00:22
Redundant specification of type arguments <Pattern>

@rnveach
Copy link
Copy Markdown
Contributor

rnveach commented Jun 11, 2023

@rnveach
Copy link
Copy Markdown
Contributor

rnveach commented Jun 11, 2023

Hmm, I wasn't expecting a merge commit to be added.

@nrmancuso
Copy link
Copy Markdown
Contributor Author

I will fix on my local, you have to manually select rebase in GitHub

@nrmancuso nrmancuso force-pushed the fix-eclipse branch 2 times, most recently from b949be8 to 4f9f606 Compare June 12, 2023 01:50
@nrmancuso nrmancuso requested a review from rnveach June 12, 2023 02:17
@romani
Copy link
Copy Markdown
Member

romani commented Jun 12, 2023

Do we know why it becomes a problem unexpectedly?

@nrmancuso
Copy link
Copy Markdown
Contributor Author

@romani The jar used for this job was compiled with jdk17, so I assume that eclipse migrated from 11 to 17

@romani
Copy link
Copy Markdown
Member

romani commented Jun 12, 2023

Better for us to stay on jdk 11 version and migrate to jdk 17 after summer .

Can we set hardcoded version at

ECJ_MAVEN_VERSION=$(wget --quiet -O- "$ECLIPSE_URL/?C=M;O=D" | grep -o "R-[^/]*" | head -n1)

Eclipse is on jdk17 https://wiki.eclipse.org/Eclipse/Installation
Idea is on jdk17 https://intellij-support.jetbrains.com/hc/en-us/articles/206544879-Selecting-the-JDK-version-the-IDE-will-run-under
Sonar still on jdk 11 for scanner (our execution environment): https://docs.sonarqube.org/latest/requirements/prerequisites-and-overview/

We should stay on jdk 11.

http://ftp-stud.fht-esslingen.de/pub/Mirrors/eclipse/eclipse/downloads/drops4/

We should use R-4.27-202303020300 , it will give us about a year on runway on this version, in a year we will decide what to do.

We should comment out line I pointed to and make new line with hardcoded value.

@nrmancuso
Copy link
Copy Markdown
Contributor Author

@romani done

@romani romani merged commit 0f6f693 into checkstyle:master Jun 13, 2023
@nrmancuso nrmancuso deleted the fix-eclipse branch June 13, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants