Skip to content

Append new line between records when using custom --format #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
obnoxxx merged 2 commits into from
Aug 25, 2025
Merged

Append new line between records when using custom --format #98

obnoxxx merged 2 commits into from
Aug 25, 2025

Conversation

@adelplanque
Copy link
Contributor

@adelplanque adelplanque commented May 8, 2024 •
edited by obnoxxx
Loading

According to the documentation, when using the --format option, each error report must end with a new line, which is not the case.

Checklist

Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

  • CI passes
  • [ X] Description of proposed change
  • [ X] Documentation (README, docs/, man pages) is updated
  • Existing issue is referenced if there is one
  • [ X] Unit tests for the proposed change

@adelplanque
Copy link
Contributor Author

adelplanque commented May 8, 2024

I just saw #55, but in #54 only deletion of \r was requested.
All lint tools I know use a breakline between error reports. The standard under Unix is a simple \n. That's why I think it would be a good idea to restore a \n at the end of each error.
Even if we obtain the same effect with {{"\n"}}, this seems to me a tricky way of proceeding for someone who does not know the Go language.
A better solution might be to add \r\n or \n depending on the OS.

@obnoxxx
Copy link
Collaborator

obnoxxx commented Jun 11, 2025

rebased on current mainbranch.

obnoxxx
obnoxxx approved these changes Aug 25, 2025
View reviewed changes
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@obnoxxx obnoxxx merged commit 542782e into checkmake:main Aug 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

+1 more reviewer

@lafrenierejm lafrenierejm lafrenierejm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adelplanque @obnoxxx @lafrenierejm