remove newline for custom formatter #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2021
2 tasks
adelplanque
added a commit
to adelplanque/flymake-makefile
that referenced
this pull request
May 8, 2024
newline was removed in checkmake/checkmake#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We've been adding newlines to the custom formatter output for no good reason.
This is breaking some tools that don't expext newlines. And if newlines are
needed they can always be added as part of the passed in custom formatter
template.
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.
fixes #54