Skip to content

Conversation

@lafrenierejm
Copy link
Contributor

@lafrenierejm lafrenierejm commented Aug 7, 2025

This fixes the current Dependabot error and enables updates for the base images in this repo's Dockerfiles.

Validation results from my fork can be seen here.

Checklist

Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 8, 2025

@lafrenierejm, Thank you for your contribution!

Before noticing your PR, I already added an initial dependabot configuration.
It conflicts your addition.

Would you please review the fifference and possibly if appropriate update this PR to be a change of the existing file?

Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the PR to modify the existing dependabot.yml file.

@lafrenierejm lafrenierejm changed the title Enable Dependabot for Go, Docker, and GitHub Actions Fix Dependabot config and enable for Dockerfile base images Aug 8, 2025
@lafrenierejm
Copy link
Contributor Author

@obnoxxx All good! I updated this PR's branch and description just now.

I noticed that the configuration that's currently in main is broken, so I would recommend merging this sooner rather later. 🙂

@lafrenierejm lafrenierejm requested a review from obnoxxx August 8, 2025 22:09
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lafrenierejm , thanks for adjusting the patch to the existing (broken) config.

And thank you for the fix!

LGTM.

@obnoxxx obnoxxx merged commit 1bc0400 into checkmake:main Aug 11, 2025
1 check passed
@lafrenierejm lafrenierejm deleted the enable-dependabot branch August 11, 2025 12:31
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 12, 2025

@lafrenierejm thanks again for the help getting this set up!

It is working now and the first few PRs with updates by dependabot have meanwhile been merged. 🎉

The latest one (#134) is not so simple though as a simple version bump is not sufficient. The API has changed and callers need to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants