-
Notifications
You must be signed in to change notification settings - Fork 52
Bump github.com/olekukonko/tablewriter from 0.0.0-20150822215231-b9346ac189c5 to 1.0.9 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/olekukonko/tablewriter from 0.0.0-20150822215231-b9346ac189c5 to 1.0.9 #134
Conversation
daaf5db to
09ea225
Compare
|
@dependabot rebase |
09ea225 to
21781d0
Compare
|
@dependabot rebase |
1 similar comment
|
@dependabot rebase |
|
@dependabot recreate |
|
Dependabot encountered an unknown error. Because of this, Dependabot cannot update this pull request. |
|
@dependabot rebase |
21781d0 to
14ca4cb
Compare
|
@dependabot recreate |
14ca4cb to
060b3b9
Compare
|
@dependabot rebase |
060b3b9 to
b0a5e3a
Compare
|
@dependabot recreate |
b0a5e3a to
77574e7
Compare
|
@dependabot rebase |
77574e7 to
3cbe9a5
Compare
|
The code is not adjusted for the new version of tablewriter. CI failure: github.com/checkmake/checkmake/formatters
Error: formatters/default.go:35:8: table.SetHeader undefined (type *tablewriter.Table has no field or method SetHeader)
Error: formatters/default.go:37:8: table.SetCenterSeparator undefined (type *tablewriter.Table has no field or method SetCenterSeparator)
Error: formatters/default.go:38:8: table.SetColumnSeparator undefined (type *tablewriter.Table has no field or method SetColumnSeparator)
Error: formatters/default.go:39:8: table.SetRowSeparator undefined (type *tablewriter.Table has no field or method SetRowSeparator)
Error: formatters/default.go:40:8: table.SetBorder undefined (type *tablewriter.Table has no field or method SetBorder)
Error: formatters/default.go:41:8: table.SetAutoWrapText undefined (type *tablewriter.Table has no field or method SetAutoWrapText)
Error: formatters/default.go:43:8: table.AppendBulk undefined (type *tablewriter.Table has no field or method AppendBulk)
|
|
@dependabot rebase |
3cbe9a5 to
8333d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing go.mod and go.sum is not sufficient.
The callers need to be adjusted for the changed API.
8333d03 to
13e7588
Compare
Bumps [github.com/olekukonko/tablewriter](https://github.com/olekukonko/tablewriter) from 0.0.0-20150822215231-b9346ac189c5 to 1.0.9. - [Commits](https://github.com/olekukonko/tablewriter/commits/v1.0.9) --- updated-dependencies: - dependency-name: github.com/olekukonko/tablewriter dependency-version: 1.0.9 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
13e7588 to
7c7504d
Compare
@obnoxxx I wonder if it would be better to target version It's newer than what's there now and is described as the version to use for "legacy applications". WDYT? |
Yes, as I discovered while working on #121, this is what we'd need to do in the meantime due to API breakage. I tried bumping all dependencies including The long term solution would require more code changes to support the new version's API. |
|
Here is a PR to bump |
@trinitronx Nice! |
|
@trinitronx wrote:
Thanks for doing this! It is merged now. and hopefully, this will be good for the time being. |
|
This has been superseded by #147 - so it can be closed. @dependabot close |
Bumps github.com/olekukonko/tablewriter from 0.0.0-20150822215231-b9346ac189c5 to 1.0.9.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)