Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 11, 2025

Bumps github.com/olekukonko/tablewriter from 0.0.0-20150822215231-b9346ac189c5 to 1.0.9.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Aug 11, 2025
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch 2 times, most recently from daaf5db to 09ea225 Compare August 11, 2025 16:37
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 11, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from 09ea225 to 21781d0 Compare August 11, 2025 16:44
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 11, 2025

@dependabot rebase

1 similar comment
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 11, 2025

@dependabot rebase

@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 11, 2025

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 11, 2025

Dependabot encountered an unknown error. Because of this, Dependabot cannot update this pull request.

@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 11, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from 21781d0 to 14ca4cb Compare August 11, 2025 17:22
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 11, 2025

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from 14ca4cb to 060b3b9 Compare August 11, 2025 17:38
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 12, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from 060b3b9 to b0a5e3a Compare August 12, 2025 08:17
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 12, 2025

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from b0a5e3a to 77574e7 Compare August 12, 2025 08:50
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 12, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from 77574e7 to 3cbe9a5 Compare August 12, 2025 09:20
@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 12, 2025

The code is not adjusted for the new version of tablewriter. CI failure:

 github.com/checkmake/checkmake/formatters
Error: formatters/default.go:35:8: table.SetHeader undefined (type *tablewriter.Table has no field or method SetHeader)
Error: formatters/default.go:37:8: table.SetCenterSeparator undefined (type *tablewriter.Table has no field or method SetCenterSeparator)
Error: formatters/default.go:38:8: table.SetColumnSeparator undefined (type *tablewriter.Table has no field or method SetColumnSeparator)
Error: formatters/default.go:39:8: table.SetRowSeparator undefined (type *tablewriter.Table has no field or method SetRowSeparator)
Error: formatters/default.go:40:8: table.SetBorder undefined (type *tablewriter.Table has no field or method SetBorder)
Error: formatters/default.go:41:8: table.SetAutoWrapText undefined (type *tablewriter.Table has no field or method SetAutoWrapText)
Error: formatters/default.go:43:8: table.AppendBulk undefined (type *tablewriter.Table has no field or method AppendBulk)

@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 14, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from 3cbe9a5 to 8333d03 Compare August 14, 2025 12:41
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing go.mod and go.sum is not sufficient.

The callers need to be adjusted for the changed API.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from 8333d03 to 13e7588 Compare August 26, 2025 13:11
Bumps [github.com/olekukonko/tablewriter](https://github.com/olekukonko/tablewriter) from 0.0.0-20150822215231-b9346ac189c5 to 1.0.9.
- [Commits](https://github.com/olekukonko/tablewriter/commits/v1.0.9)

---
updated-dependencies:
- dependency-name: github.com/olekukonko/tablewriter
  dependency-version: 1.0.9
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@obnoxxx obnoxxx force-pushed the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch from 13e7588 to 7c7504d Compare August 26, 2025 14:41
@eread
Copy link
Contributor

eread commented Aug 26, 2025

changing go.mod and go.sum is not sufficient.

TRhe callers need to be adjusted for the changed API.

@obnoxxx I wonder if it would be better to target version 0.0.5 in the short term: https://github.com/olekukonko/tablewriter?tab=readme-ov-file#installation?

It's newer than what's there now and is described as the version to use for "legacy applications".

WDYT?

@trinitronx
Copy link
Contributor

I wonder if it would be better to target version 0.0.5 in the short term:

Yes, as I discovered while working on #121, this is what we'd need to do in the meantime due to API breakage. I tried bumping all dependencies including tablewriter, but I had to revert tablewriter to version 0.0.5.

The long term solution would require more code changes to support the new version's API.

@trinitronx
Copy link
Contributor

Here is a PR to bump tablewriter to v0.0.5: #147

@eread
Copy link
Contributor

eread commented Aug 27, 2025

Here is a PR to bump tablewriter to v0.0.5: #147

@trinitronx Nice!

@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 28, 2025

@trinitronx wrote:

Here is a PR to bump tablewriter to v0.0.5: #147

Thanks for doing this! It is merged now.

and hopefully, this will be good for the time being.

@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 29, 2025

This has been superseded by #147 - so it can be closed.

@dependabot close

@dependabot dependabot bot closed this Aug 29, 2025
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/olekukonko/tablewriter-1.0.9 branch August 29, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants