Improve the maxbodylength rule description #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mentions that maxbodylength is in number of lines. Fixes: checkmake#90 Signed-off-by: Michael Adam <obnox@samba.org>
5 tasks
ada1ac1 to
278efef
Compare
The description of the maxbodylength rule shown with --list-rules
weas not very specific:
maxbodylength Target bodies should be kept
simple and short.
This change adds the detail that length refers to a certain maximum
number of lines:
maxbodylength Target bodies should be kept
simple and short(no more than
5 lines).
Signed-off-by: Michael Adam <obnox@samba.org>
278efef to
5baeea9
Compare
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is a follow-up to PR #109 depending on it) and a partial solution to issue #108
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.