rules: clarify the violation message for maxbodylength #109
Conversation
|
@mrtazz why are no CI checks being run on this PR? is anything wrong with the PR itself? |
hmm that's odd. I don't think this is your PR. I'll take a look. Thanks for spotting that typo and for taking the time to contribute! update: fixed in #110 |
This mentions that maxbodylength is in number of lines. Fixes: checkmake#90 Signed-off-by: Michael Adam <obnox@samba.org>
d2fb38f to
0db4c22
Compare
|
@mrtazz wrote:
Thanks for confirming my thinking.
To be really petty, I don't consider this a typo but rather a gap in functionality or convenience. It was noted in issue #90 before. My observation was related to me raising #108 when I tried to understand better what the various rules really mean.
Thank you for creating this open-source project!
fantastic! it worked and the CI passed. 😄 |
|
@mrtazz , In addition to the change in this patch, I am thinking to expand the |
|
yea absolutely, that description has probably been there since the start when I just quickly jotted it down while sketching out the project. I have some additional thoughts related to #108 but will write them down there |
|
@mrtazz , I could add a commit to update the description to this PR itself or create a separate one (bow or after this is merged). Which do you prefer? Anyway, I guess I'm just going to create a separate PR depending on this one... |
|
PR #111 created, depending on this one, with the improved description. |
This mentions that maxbodylength is in number of lines.
Resolves: #90
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.