Added Dataframe output format#6
Merged
Merged
Conversation
f6de615 to
4681d7a
Compare
auxten
reviewed
Apr 15, 2023
d65027d to
7b9fa38
Compare
auxten
pushed a commit
that referenced
this pull request
Jun 27, 2023
auxten
pushed a commit
that referenced
this pull request
Jun 28, 2023
Member
|
@all-contributors please add @nmreadelf for code |
Contributor
|
I've put up a pull request to add @nmreadelf! 🎉 |
auxten
pushed a commit
that referenced
this pull request
Aug 15, 2023
auxten
pushed a commit
that referenced
this pull request
Nov 9, 2023
auxten
pushed a commit
that referenced
this pull request
Jun 7, 2024
wudidapaopao
added a commit
to wudidapaopao/chdb-core-fork
that referenced
this pull request
Feb 26, 2026
Upgrade CH version to v26.1.2.11
auxten
added a commit
that referenced
this pull request
May 21, 2026
The previous empty-result short-circuit in ``test_random_chain_matches_pandas`` checked ``isinstance(ds_result, pd.DataFrame)``, but ``apply_chain`` returns a lazy ``DataStore``, not a materialized ``pd.DataFrame`` - so the isinstance branch was always False and the short-circuit never fired. CI on commit 64f38b8 surfaced this when Hypothesis generated the chain ``filter(v>0) -> filter(v>99) -> sort(w desc) -> groupby(cat).agg({'v':'sum'})`` (empty intermediate after the second filter; column drift between pandas' agg-projected output and DataStore's source-bound short-circuit output). Two changes: - ``tests/test_property_based_chains.py``: replace the isinstance check with a duck-typed ``len(r) == 0`` helper that works on ``DataStore`` and ``pd.DataFrame`` alike. Reference the new journey test in the comment so future readers can find the tracked bug. - ``tests/journeys/test_property_chain_followups.py`` (new): verbatim regression for the falsifying chain, marked ``@unittest.expectedFailure``. Follows the ``.cursor/rules/chdb-ds.mdc`` rule #6 contract: every Hypothesis falsifier becomes a permanent journey test; when the underlying empty-intermediate column-projection bug in the executor is fixed, flip the xfail and drop the property-test skip in the same commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Dataframe output format