test(datastore): require chdb-core>=26.5.0; un-xfail Array-in-Nullable cases it fixes#588
Merged
ShawnChen-Sirius merged 1 commit intoJun 9, 2026
Conversation
…e cases it fixes
chdb-core v26.5 removes the "Array(T) cannot be inside Nullable" limitation, so
str.findall / splitByWhitespace over nullable columns now work. Drop the
@chdb_array_nullable xfail from the three tests that genuinely pass on v26.5:
- test_str_findall
- test_raw_sql_split_without_ifnull_fails
- test_array_in_nullable (also fix a stale ._get_df() call on a ColumnExpr;
materialize via len() per the lazy-execution convention)
test_explode_series keeps its strict=True xfail: it fails for an unrelated
reason (explode's arrayJoin does not convert a Python-list column to Array(T)),
not the Nullable limitation, so xfail_markers.py is unchanged.
Bump the chdb-core dependency floor to >=26.5.0 (requirements.txt, pyproject.toml).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wudidapaopao
pushed a commit
to chdb-io/chdb-core
that referenced
this pull request
Jun 10, 2026
The chdb-io datastore xfail markers were fixed upstream and shipped in chdb v4.1.9 (chdb-io#588): the Array-in-Nullable cases that genuinely pass on the v26.5 engine no longer carry @chdb_array_nullable, so the strict=False shim is obsolete. test_chdb_datastore.sh clones the latest chdb release (now v4.1.9), so remove the shim file and its invocation. Also fix the wheel-build trigger: `release: types: [created]` misses releases that are saved as a draft and published later (the chdb-core v26.5.0 release hit exactly this — the publish workflows never fired, leaving PyPI/release assets empty until a manual workflow_dispatch). Switch all four workflows to `types: [published]`, which fires on direct publish and on publishing a draft. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
chdb-core v26.5 removes the "Array(T) cannot be inside Nullable" limitation, so
str.findall/splitByWhitespaceover nullable columns now work. This drops the@chdb_array_nullablexfail from the three datastore tests that genuinely pass on v26.5,and raises the
chdb-coredependency floor to>=26.5.0.Changes
test_str_findalltest_raw_sql_split_without_ifnull_failstest_array_in_nullable— also fixes a stale._get_df()call on aColumnExpr(materialize via
len(), per the lazy-execution convention)strict=TrueXFAIL:test_explode_series— fails for an unrelated reason(explode's
arrayJoindoesn't convert a Python-list column toArray(T)), not theNullable limitation.
xfail_markers.pyis therefore unchanged.chdb-core>=26.1.0→>=26.5.0inrequirements.txtandpyproject.toml.Validation
Ran the 4 affected tests against
chdb-core==26.5.0(engine 26.5.1.1):3 passed, 1 xfailed—strict=Truepreserved (no XPASS).🤖 Generated with Claude Code