Migrate the PR-CI lint gate from flake8 to ruff #567
Merged
Conversation
Drop-in replacement preserving rule selection (E9, F63, F7, F82), ignores (F811, __init__.py:F401), line-length 120, and the same exclude list. Verified locally: ruff 0.15.12 scans 43 datastore files in ~7 ms with zero findings — exact parity with flake8 on the current codebase. Files changed: - pyproject.toml: add [tool.ruff] (config previously in setup.cfg) - requirements-dev.txt: flake8>=6.0.0 -> ruff>=0.5.0 - setup.cfg: removed (only contained the [flake8] section) - .github/workflows/pr_ci.yaml: install + invoke ruff Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ShawnChen-Sirius
added a commit
to ShawnChen-Sirius/chdb
that referenced
this pull request
May 14, 2026
Migrate chdb's CLAUDE.md (chdb-ds Design and Testing Principles) to AGENTS.md, keeping the content unchanged but reformatting it to follow the agents.md open standard (https://agents.md). AGENTS.md is deliberately short — it stays loaded in AI coding agent context at all times, so it only carries the design and testing principles. Everything human-facing (setup, the modify-then-test workflow, things to avoid, PR conventions, CI matrix, security, maintainer release flow) moves into CONTRIBUTING.md. README.md, the PR template, and the issue templates now point contributors there. Companion changes: - Replace the inherited ClickHouse-upstream .github/ISSUE_TEMPLATE/ set with chdb-specific bug_report.md, feature_request.md, performance_issue.md, and a config.yml routing block. - Modernise .github/PULL_REQUEST_TEMPLATE.md and adopt the ClickHouse-style PR title convention (Capitalised verb start, no Conventional-Commit prefix). - Repoint .cursor/rules/{chdb,chdb-ds,git-conventions}.mdc at AGENTS.md / CONTRIBUTING.md instead of duplicating their content. - Reflect ruff (replacing flake8) as the only PR-gate lint, matching upstream PR chdb-io#567. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
flake8 datastorewithruff check datastoreas the PR-CIlint gate. Pure drop-in: same rule selection (E9, F63, F7, F82),
same ignores (F811,
__init__.py:F401), same line-length (120),same exclude list. No
.pysource files change.Resolves #566.
Type of change
chore— tooling, dependencies, housekeepingLinked issues
Closes #566
How to verify
Locally on this branch (verified):