Skip to content

Fix starving caused by GIL#289

Merged
auxten merged 2 commits intomainfrom
patchset-2.2.0b1
Dec 12, 2024
Merged

Fix starving caused by GIL#289
auxten merged 2 commits intomainfrom
patchset-2.2.0b1

Conversation

@auxten
Copy link
Copy Markdown
Member

@auxten auxten commented Dec 9, 2024

  • Fix starving caused by GIL

    Calling isInheritsFromPyReader()(Need acquire GIL) from Chunk PythonSource::generate() will cause hard to re-produce deadlock. The Python thread might already hold GIL, and waiting for ClickHouse engine returning data, but the pipeline running is also wait for GIL💥
    We should doing everything require GIL before the pipeline start!

@auxten auxten merged commit 01afb91 into main Dec 12, 2024
auxten added a commit that referenced this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant