Add support for Swift V1 Auth #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayme-github
added a commit
to jayme-github/chartmuseum
that referenced
this pull request
Jun 26, 2020
This adds support for Swift V1 Auth sharing all of the config options with openstack. I've added a new option (--storage-openstack-auth) to switch to V1 Auth. This depends on chartmuseum/storage#45 Signed-off-by: jayme-github <jayme-github@users.noreply.github.com>
gophercloud's AuthOptionsFromEnv does not support Swift V1 Auth directly. I added NewOpenstackOSBackendV1Auth to support that. Signed-off-by: jayme-github <jayme-github@users.noreply.github.com>
Signed-off-by: jayme-github <jayme-github@users.noreply.github.com>
947e817 to
70deb73
Compare
jdolitsky
pushed a commit
to helm/chartmuseum
that referenced
this pull request
Jul 14, 2020
This adds support for Swift V1 Auth sharing all of the config options with openstack. I've added a new option (--storage-openstack-auth) to switch to V1 Auth. This depends on chartmuseum/storage#45 Signed-off-by: jayme-github <jayme-github@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gophercloud's
AuthOptionsFromEnv()does not support Swift V1 Auth[1] directly.I added NewOpenstackOSBackendV1Auth to support that.
The second commit tries to add running test for Swift V1 Auth in CI but I must admit that I have no experience with codefresh and have not tested that change yet.
[1] https://www.swiftstack.com/docs/cookbooks/swift_usage/auth.html#v1-auth