Replace horizontalBar with indexAxis: 'y' #7514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It might be useful to have a test where the x and y axes have different IDs to make sure that |
etimberg
reviewed
Jun 16, 2020
Member
Author
Good catch, it didn't actually work. Fixed and added a mixed test. |
Contributor
|
I think this closes #4047 as well |
etimberg
approved these changes
Jun 17, 2020
benmccann
approved these changes
Jun 18, 2020
Contributor
benmccann
left a comment
There was a problem hiding this comment.
awesome. I'm super happy about this!
scatter next? ;-)
Member
Author
Not sure what you mean, this works for scatter too: https://codepen.io/kurkle/pen/JjGbVeG?editors=1010 |
Contributor
|
I meant maybe we should find figure out how to delete it next |
etimberg
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Replace horizontalBar with indexAxis: 'y' * Fix drawing of line for last x-position * Consistently determine axis of scale * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting this one (original #7144)
Resolves: #4096, resolves: #4047
Pen