feat: allow to set a server banner #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
approved these changes
Jan 4, 2024
Member
aymanbagabas
left a comment
There was a problem hiding this comment.
Noice! Perhaps introducing BannerHandler in Server would be useful as well
caarlos0
added a commit
to charmbracelet/wish
that referenced
this pull request
Jan 4, 2024
closes #205 needs charmbracelet/ssh#10 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This was referenced Jan 4, 2024
Merged
Member
Author
instead the banner string directly? |
Member
We can have both. Use |
aymanbagabas
approved these changes
Jan 4, 2024
caarlos0
added a commit
to charmbracelet/wish
that referenced
this pull request
Jan 4, 2024
* feat: support server banners closes #205 needs charmbracelet/ssh#10 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: banner Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: dep Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * feat: banner handler Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * go mod tidy Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: improve example Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs charmbracelet/wish#205