fix(pager): memory/cpu usage when using soft-wrap#827
Merged
Conversation
easily reproducible, especially with something like ```sh PAGER="gum pager" man ls ``` Problems here were: - reflow's truncate is not very efficient - useless calls to truncate - bad strings.Replace calls (not necessary, and wouldn't work if text has ansi sequences)
Contributor
Author
|
also worth noting: memory usage, before x after
PS: first screenshot is just opening gum pager, second is navigating, otherwise there's actually no allocations ;) |
caarlos0
added a commit
that referenced
this pull request
Jan 28, 2025
Used this in #827 and found it quite useful. Should we ship this to help both we and our users to see mem/cpu usage etc?
meowgorithm
approved these changes
Jan 28, 2025
Closed
aymanbagabas
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
easily reproducible, especially with something like
PAGER="gum pager" man lsProblems here were:
Fixes #823
PS: this is better handled in #791, but that one is a bigger change (and depends on a /bubbles change as well), so I think we can probably do this instead for now and push a patch until #791 is done and merged.
before:
fixed on regular usage, search still broken
full fix