examples/test.sh: Fixes broken table example#685
Closed
hxlnt wants to merge 1 commit intocharmbracelet:mainfrom
Closed
examples/test.sh: Fixes broken table example#685hxlnt wants to merge 1 commit intocharmbracelet:mainfrom
hxlnt wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Contributor
|
this is actually a bug in the table component, fixed in #716 thanks for the PR though 🙏🏻 |
Author
|
The linked PR doesn't appear to fix the CSV link. (Added for clarity: The added "../" brings the CSV path up a level.) |
Contributor
|
ah, right! |
caarlos0
reviewed
Nov 18, 2024
caarlos0
added a commit
that referenced
this pull request
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken portion of examples/test.sh due to incorrect path to CSV. Also adds a
--height=12to work around current bug where height is set to 0 if not specified.