Options for showing permissions and size#495
Closed
dzonekl wants to merge 2 commits intocharmbracelet:mainfrom
Closed
Options for showing permissions and size#495dzonekl wants to merge 2 commits intocharmbracelet:mainfrom
dzonekl wants to merge 2 commits intocharmbracelet:mainfrom
Conversation
dzonekl
commented
Feb 8, 2024
| Cursor string `short:"c" help:"The cursor character" default:">" env:"GUM_FILE_CURSOR"` | ||
| All bool `short:"a" help:"Show hidden and 'dot' files" default:"false" env:"GUM_FILE_ALL"` | ||
| Permissions bool `short:"p" help:"Show file permissions" default:"false" env:"GUM_FILE_PERMISSION"` | ||
| Size bool `short:"s" help:"Show file size" default:"false" env:"GUM_FILE_SIZE"` |
maaslalani
reviewed
Feb 29, 2024
Comment on lines
+16
to
+17
| Permissions bool `short:"p" help:"Show file permissions" default:"false" env:"GUM_FILE_PERMISSION"` | ||
| Size bool `short:"s" help:"Show file size" default:"false" env:"GUM_FILE_SIZE"` |
Contributor
There was a problem hiding this comment.
I think we should default to true, what do you think? Then we can add the negatable:"" option to allow for people to do --no-permissions and --no-size.
Author
There was a problem hiding this comment.
Yes indeed, that way default would remain as is.
caarlos0
added a commit
that referenced
this pull request
Nov 15, 2024
Contributor
|
so sorry this got stale :( thanks for the PR <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes