Skip to content

fix: properly detect terminal size after exec#499

Closed
knz wants to merge 2 commits intocharmbracelet:masterfrom
knz:20221007-fix-resize-outside-of-tea
Closed

fix: properly detect terminal size after exec#499
knz wants to merge 2 commits intocharmbracelet:masterfrom
knz:20221007-fix-resize-outside-of-tea

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Oct 7, 2022

See commits for details. Found while investigating #497.

cc @muesli

@knz knz force-pushed the 20221007-fix-resize-outside-of-tea branch from 7e044f4 to 4e68f4f Compare October 7, 2022 13:59
This was referenced Oct 7, 2022
Open
Open
@muesli muesli added the bug Something isn't working label Oct 7, 2022
@muesli
Copy link
Copy Markdown
Contributor

muesli commented Oct 12, 2022

We could also use checkResize to ensure an initial terminal size is known before the first render 🤔

@muesli
Copy link
Copy Markdown
Contributor

muesli commented Oct 13, 2022

Rebasing.

muesli added a commit that referenced this pull request Oct 15, 2022
@muesli
fix: detect terminal size after exec
b4bdb8c 
Based on @knz's work in #499, but slightly supersedes this change.

A little more coupling in the resize handling, but a lot less code
& logic repetition.
@muesli muesli mentioned this pull request Oct 15, 2022
Merged
muesli added a commit that referenced this pull request Oct 15, 2022
@muesli
fix: detect terminal size after exec
e55f134 
Based on @knz's work in #499, but slightly supersedes this change.

A little more coupling in the resize handling, but a lot less code
& logic repetition.
@muesli
Copy link
Copy Markdown
Contributor

muesli commented Oct 15, 2022

Superseded by #541 which is based on this PR, but goes a step further and fixes a race condition accessing the Program's ctx. Thank you, once again, @knz!

@muesli muesli closed this Oct 15, 2022
muesli added a commit that referenced this pull request Oct 22, 2022
@muesli @knz
fix: detect terminal size after exec
30a9b70 
Based on @knz's work in #499, but slightly supersedes this change.

A little more coupling in the resize handling, but a lot less code
& logic repetition.

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
muesli added a commit that referenced this pull request Oct 22, 2022
@muesli @knz
fix: detect terminal size after exec
80f44c9 
Based on @knz's work in #499, but slightly supersedes this change.

A little more coupling in the resize handling, but a lot less code
& logic repetition.

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@knz @muesli