Skip to content

feat: support key bindings in textinput like textarea#270

Merged
maaslalani merged 1 commit intocharmbracelet:masterfrom
knz:20221007-textinput-bindings
Oct 7, 2022
Merged

feat: support key bindings in textinput like textarea#270
maaslalani merged 1 commit intocharmbracelet:masterfrom
knz:20221007-textinput-bindings

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Oct 7, 2022

@maaslalani
Copy link
Copy Markdown
Contributor

Thanks @knz, this looks great! Testing now

@maaslalani
Copy link
Copy Markdown
Contributor

Just some small notes but the PR works perfectly, really great work @knz. Thank you so much! Really nice to see that Alt check basically disappear from the default case.

@knz knz force-pushed the 20221007-textinput-bindings branch from fc0ee71 to a5f11a7 Compare October 7, 2022 15:20
@maaslalani maaslalani merged commit 9a48dca into charmbracelet:master Oct 7, 2022
@knz knz deleted the 20221007-textinput-bindings branch October 7, 2022 15:40
@knz knz mentioned this pull request Oct 7, 2022
34 tasks
youyoumu pushed a commit to youyoumu/bubbles that referenced this pull request Jan 19, 2025
* docs: add another progress bar example

* chore: copy edits

Co-authored-by: Christian Rocha <christian@rocha.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

textinput: doesn't support customizable key bindings

2 participants