Skip to content

feat(textarea/textinput): support overwrite mode#225

Closed
knz wants to merge 1 commit intocharmbracelet:masterfrom
knz:insert-key
Closed

feat(textarea/textinput): support overwrite mode#225
knz wants to merge 1 commit intocharmbracelet:masterfrom
knz:insert-key

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Aug 25, 2022

@knz knz force-pushed the insert-key branch 2 times, most recently from 8949f01 to c767280 Compare August 25, 2022 16:05
@knz knz mentioned this pull request Aug 25, 2022
34 tasks
@muesli muesli added the enhancement New feature or request label Sep 27, 2022
@muesli
Copy link
Copy Markdown
Contributor

muesli commented Oct 6, 2022

@knz Mind rebasing this for us?

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Oct 6, 2022

Done, but note that for this to build properly it needs a release of bubbletea that contains charmbracelet/bubbletea#418

Otherwise, I'd need to update the textinput bubble to use key.Binding (which is what textarea does already). I know we've talked with @maaslalani about this but I don't have a PR for it yet.

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Oct 7, 2022

Alternatively I can rebase this on top of #270 so it does not need a go.mod update immediately. WDYT?

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Oct 7, 2022

Ok, done. This is now ready.

@knz knz changed the title Support overwrite mode in textarea/textinput feat(textarea/textinput): support overwrite mode Oct 7, 2022
@muesli muesli requested a review from maaslalani October 21, 2022 14:46
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Nov 6, 2022

@maaslalani anything else you'd like to happen here?

@maaslalani
Copy link
Copy Markdown
Contributor

Hey! I think this might make sense in a perhaps opt-in setting for the textarea.

We also have vim-mode support (potentially):

So, I think we might be able to make these, either opt-in, or part of a separate (more fully-featured textarea).

I will close this for now since I'm cleaning up some old PRs, but feel free to reopen as I think it does make sense in the future.

@maaslalani maaslalani closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants