Merged
Conversation
Contributor
|
This is great! I've been sad/afraid/amazed that there were no tests for this big bag of heuristics. |
Contributor
Author
|
Any news yet? Maybe you want me to rebase this to your repository instead of @dcramer's? |
dan-blanchard
added a commit
that referenced
this pull request
Dec 11, 2013
Add unit tests from Mark Pilgrim's original repository.
dan-blanchard
pushed a commit
that referenced
this pull request
Dec 15, 2013
The BOM detection was comparing str instances with bytes instances. e.g. b'\xEF\xBB\xBF' == '\xEF\xBB\xBF' Test status before commit: 377 tests 25 failures Test status after commit: 382 tests 25 failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the tests from Mark Pilgrim's original repository at Google Code, plus the tests from modern web browsers and similar chardet projects.
P.S. I've also put a pull req on @dcramer's repository: dcramer/chardet#6