Skip to content

upgrade eslint to v10 and update config#1876

Merged
bluwy merged 22 commits intochangesets:nextfrom
beeequeue:eslint10
May 4, 2026
Merged

upgrade eslint to v10 and update config#1876
bluwy merged 22 commits intochangesets:nextfrom
beeequeue:eslint10

Conversation

@beeequeue
Copy link
Copy Markdown

@beeequeue beeequeue commented Mar 6, 2026

part of #1869

  • there are various rules marked as TODO enable and fix errors which are good to have but have too many errors and will be fixed in follow-up PRs
  • i personally love sorted imports, but i know they're not everyone's cup of tea - should i add it in another PR?
  • i will add all the formatting/fixing commits to the .git-blame-ignore-revs file in the follow-up PRs.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 6, 2026

⚠️ No Changeset found

Latest commit: d0cc702

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@beeequeue beeequeue force-pushed the eslint10 branch 2 times, most recently from 456ac69 to 060529c Compare March 6, 2026 00:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.99%. Comparing base (b9407b3) to head (d0cc702).
⚠️ Report is 1 commits behind head on next.

Files with missing lines Patch % Lines
packages/get-github-info/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1876   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files          54       54           
  Lines        2461     2461           
  Branches      718      719    +1     
=======================================
  Hits         2018     2018           
  Misses        400      400           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Andarist
Copy link
Copy Markdown
Member

Andarist commented Mar 8, 2026

should prefer-const be enabled? i see let being used in most places so i assume its by choice, but could you explain why? @Andarist

This predates my involvement with the project ;p it was just a preference of some of the previous maintainers or smth.

@beeequeue
Copy link
Copy Markdown
Author

then i'll mark it as a follow-up pr as well 😄

@beeequeue beeequeue marked this pull request as ready for review March 8, 2026 15:07
Comment thread packages/cli/src/index.ts
Comment thread packages/get-github-info/src/index.ts
@Andarist
Copy link
Copy Markdown
Member

@beeequeue could you sync this with next?

@beeequeue
Copy link
Copy Markdown
Author

beeequeue commented Mar 25, 2026

i'm thinking we should merge this after #1879 since it touches a lot of files and the rebase would likely be quite a task if this one was merged first, while rebasing this pr is just re-running eslint fix on the conflicting files

@beeequeue beeequeue mentioned this pull request Apr 30, 2026
19 tasks
@Netail
Copy link
Copy Markdown
Contributor

Netail commented Apr 30, 2026

Could potentially also be Biome or OXC ;)

@beeequeue beeequeue added this to the v3 milestone May 4, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 4, 2026

@Andarist
Copy link
Copy Markdown
Member

Andarist commented May 4, 2026

@Netail we plan to explore the switch once v3 gets released

@bluwy
Copy link
Copy Markdown
Member

bluwy commented May 4, 2026

Personally I think it's fine to not add it given the assorted changes here, plus it's not too noisy

@beeequeue
Copy link
Copy Markdown
Author

some of the fixes will be quite noisy i think, but i can do it only for those

@bluwy bluwy requested a review from Andarist May 4, 2026 14:16
@bluwy bluwy merged commit 068d933 into changesets:next May 4, 2026
9 of 10 checks passed
@beeequeue beeequeue deleted the eslint10 branch May 4, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants