docs(color-mode): updates docsite to reflect current behavior#1062
docs(color-mode): updates docsite to reflect current behavior#1062andrejsshell merged 9 commits intochakra-ui:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Adding this comment to make clear that requested changes are now included in 1d1ec8b commit , all but one. The one still unresolved is #1062 (review) |
|
Other than the comment I wrote, everything looks okay on my end! When it has been resolved we can merge this! |
Great to hear that ! My feature branch is behind |
Hey, you need to go to your fork and click this button and then merge the main branch into yours. |
|
Merged. Let me know if something else need to be done on my end. |
andrejsshell
left a comment
There was a problem hiding this comment.
One small thing, these two look too much in my opinion, can you maybe make the first Alert as a text and see how it looks?
andrejsshell
left a comment
There was a problem hiding this comment.
This is perfect, thanks a lot. Merging this 🚀
Awesome ! Happy end of year Andrej. |
📝 Description
Update doc page for
Color Modeto reflect current behavior.⛳️ Current behavior (updates)
Current doc suggest a wrong use of the
Color ModeAPI.Current docs refers to Chakra v1 behavior of the Color Mode, not to v2.
🚀 New behavior
Help newcomers to understand current behavior and avoid confusion.
Proposed changes:
💣 Is this a breaking change (Yes/No): No
📝 Additional Information
Chakra v2 updated the code (as stated here and here ) and confirmed by a codesandbox i created to test).
There are two
sentencesthat need to be reviewed, these will be commented in PR comments.tresorama