Skip to content

Docs/fix daily workflow pr#4410

Merged
with-heart merged 4 commits intochakra-ui:mainfrom
tomchentw:docs/fix-daily-workflow-pr
Jul 19, 2021
Merged

Docs/fix daily workflow pr#4410
with-heart merged 4 commits intochakra-ui:mainfrom
tomchentw:docs/fix-daily-workflow-pr

Conversation

@tomchentw
Copy link
Copy Markdown
Contributor

@tomchentw tomchentw commented Jul 19, 2021

@with-heart I saw you merged #4314. Unfortunately it contains bugs. This PR fixes them.

📝 Description

  • Fixes workflow run order
  • Fixes committing website/avatars folder

⛳️ Current behavior (updates)

The workflow failed: https://github.com/chakra-ui/chakra-ui/actions/runs/1043440696

🚀 New behavior

The workflow succeeds. This was tested on my forked repo:
https://github.com/tomchentw/chakra-ui/runs/3100486439

Here's the test branch with its generated commits: main...tomchentw:docs/daily-workflow-fix

JPEG-1

💣 Is this a breaking change (Yes/No):

No.

📝 Additional Information

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 19, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4de119e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/7GCPoiC365NgLcucBckvSAa96HHW
✅ Preview: https://chakra-ui-git-fork-tomchentw-docs-fix-daily-wo-b7fcd9-chakra-ui.vercel.app

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jul 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4de119e:

Sandbox Source
create-react-app-ts Configuration

@with-heart
Copy link
Copy Markdown
Contributor

with-heart commented Jul 19, 2021

Thanks for fixing that! Prompt service 😁

@with-heart with-heart merged commit 7691513 into chakra-ui:main Jul 19, 2021
@tomchentw tomchentw deleted the docs/fix-daily-workflow-pr branch July 19, 2021 15:44
@with-heart
Copy link
Copy Markdown
Contributor

with-heart commented Jul 19, 2021

@tomchentw Are you on our Discord? Would love to chat more with you sometime. You've been doing some great work!

@tomchentw
Copy link
Copy Markdown
Contributor Author

tomchentw commented Jul 20, 2021

I should add the job.if check so that it only runs on github.repository is here

@tomchentw
Copy link
Copy Markdown
Contributor Author

tomchentw commented Jul 24, 2021

JPEG-1

! [remote rejected] main -> main (protected branch hook declined)

https://github.com/chakra-ui/chakra-ui/runs/3148138804?check_suite_focus=true

@tomchentw tomchentw mentioned this pull request Jul 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomchentw @with-heart