Skip to content

Docs/daily workflow#4314

Merged
with-heart merged 3 commits intochakra-ui:mainfrom
tomchentw:docs/daily-workflow
Jul 18, 2021
Merged

Docs/daily workflow#4314
with-heart merged 3 commits intochakra-ui:mainfrom
tomchentw:docs/daily-workflow

Conversation

@tomchentw
Copy link
Copy Markdown
Contributor

📝 Description

Runs these two scripts daily on GitHub Actions and commit the results to the repository:

  • yarn avatars:gen
  • yarn members:gen

⛳️ Current behavior (updates)

These scripts needs to be run by parts of the build process.

🚀 New behavior

Runs these two scripts daily on GitHub Actions. This saves time for local development as well as reducing the API usage.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 1, 2021

⚠️ No Changeset found

Latest commit: f9a3771

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/57z5pwhyY39qiPyTSSyKtQV6G9EX
✅ Preview: https://chakra-ui-git-fork-tomchentw-docs-daily-workflow-chakra-ui.vercel.app

[Deployment for f9a3771 failed]

@with-heart with-heart added Topic: Build and Workflow ↩️ Issue or PR related to build process and workflow automation Topic: Website 🖥 Issues and PRs relating to the Chakra UI website labels Jul 8, 2021
Copy link
Copy Markdown
Contributor

@with-heart with-heart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice little improvement to our workflows. I like the idea of removing the gen commands from the docs build itself as it's not really a direct concern.

Comment thread package.json Outdated
Comment on lines +60 to +61
"docs:deploy": "yarn build && yarn docs:build-ci && cp -r website/public .",
"docs:build-ci": "yarn members:gen && yarn docs:build",
"docs:build": "yarn avatars:gen && yarn search-meta:gen && yarn docs build",
"docs:dev": "yarn avatars:gen && yarn docs dev",
"docs:build-ci": "yarn docs:build",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the docs:build-ci script? We can just use yarn docs:build in docs:deploy now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@with-heart now removed

@with-heart
Copy link
Copy Markdown
Contributor

@allcontributors please add @tomchentw for infra

@allcontributors
Copy link
Copy Markdown
Contributor

@with-heart

I've put up a pull request to add @tomchentw! 🎉

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9a3771:

Sandbox Source
create-react-app-ts Configuration

@with-heart
Copy link
Copy Markdown
Contributor

Thank you!

@with-heart with-heart merged commit 6c11a2f into chakra-ui:main Jul 18, 2021
@tomchentw tomchentw deleted the docs/daily-workflow branch July 19, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Topic: Build and Workflow ↩️ Issue or PR related to build process and workflow automation Topic: Website 🖥 Issues and PRs relating to the Chakra UI website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants