test: exclude jshost from ch only test #4696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalinfinity
approved these changes
Feb 17, 2018
Contributor
digitalinfinity
left a comment
There was a problem hiding this comment.
For my own curiosity- what in this test doesn't work with jshost?
boingoing
approved these changes
Feb 17, 2018
Contributor
boingoing
left a comment
There was a problem hiding this comment.
Looks fine to me, we should probably support this in jshost, too.
Collaborator
Author
|
@digitalinfinity jshost re-uses the source code string |
Collaborator
Author
|
@digitalinfinity @boingoing Thanks for the reviews! |
chakrabot
pushed a commit
that referenced
this pull request
Feb 17, 2018
Merge pull request #4696 from obastemur:jshost_exc
chakrabot
pushed a commit
that referenced
this pull request
Feb 17, 2018
…test Merge pull request #4696 from obastemur:jshost_exc
chakrabot
pushed a commit
that referenced
this pull request
Feb 17, 2018
…from ch only test Merge pull request #4696 from obastemur:jshost_exc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.