Skip to content

fix assert in JIT data serialization #4684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chakrabot merged 2 commits into from
Feb 15, 2018
Merged

fix assert in JIT data serialization #4684

chakrabot merged 2 commits into from
Feb 15, 2018

Conversation

@MikeHolman
Copy link
Contributor

@MikeHolman MikeHolman commented Feb 14, 2018

We may have multiple codegen calls for same entrypoint, so replace the old JIT data if this happens

OS: 15845157

@MikeHolman MikeHolman requested a review from sigatrev February 14, 2018 23:23
agarwal-sandeep
agarwal-sandeep approved these changes Feb 15, 2018
View reviewed changes
Copy link
Collaborator

@agarwal-sandeep agarwal-sandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chakrabot chakrabot merged commit e1049e5 into chakra-core:release/1.8 Feb 15, 2018
chakrabot pushed a commit that referenced this pull request Feb 15, 2018
@MikeHolman
[MERGE #4684 @MikeHolman] fix assert in JIT data serialization
b7fdba0 
Merge pull request #4684 from MikeHolman:serializedassert

We may have multiple codegen calls for same entrypoint, so replace the old JIT data if this happens

OS: 15845157
chakrabot pushed a commit that referenced this pull request Feb 15, 2018
@MikeHolman
[1.8>1.9] [MERGE #4684 @MikeHolman] fix assert in JIT data serialization
c806128 
Merge pull request #4684 from MikeHolman:serializedassert

We may have multiple codegen calls for same entrypoint, so replace the old JIT data if this happens

OS: 15845157
chakrabot pushed a commit that referenced this pull request Feb 15, 2018
@MikeHolman
[1.9>master] [1.8>1.9] [MERGE #4684 @MikeHolman] fix assert in JIT da…
46085eb 
…ta serialization

Merge pull request #4684 from MikeHolman:serializedassert

We may have multiple codegen calls for same entrypoint, so replace the old JIT data if this happens

OS: 15845157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sigatrev sigatrev sigatrev approved these changes

@agarwal-sandeep agarwal-sandeep agarwal-sandeep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MikeHolman @sigatrev @agarwal-sandeep @chakrabot