ch: use copy instead of direct sourmap cache #4683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we load the same cached source file twice, ch won't track that and free the buffer twice.
|
LGTM, but I have no context what/how SourceMap is used, maybe @jackhorton can take a look? |
Contributor
|
I cant say I have a ton of context either, but it looks reasonable to me? |
Collaborator
Author
|
@dotnet-bot test OSX static_osx_osx_debug please |
Collaborator
Author
|
@jianchun @jackhorton Thanks for the review! |
chakrabot
pushed a commit
that referenced
this pull request
Feb 16, 2018
Merge pull request #4683 from obastemur:fix_m2free In case we load the same cached source file twice, ch won't track that and free the buffer twice. Originally reported by OSS-FUZZ OS#15921043
chakrabot
pushed a commit
that referenced
this pull request
Feb 17, 2018
…rmap cache Merge pull request #4683 from obastemur:fix_m2free In case we load the same cached source file twice, ch won't track that and free the buffer twice. Originally reported by OSS-FUZZ OS#15921043
chakrabot
pushed a commit
that referenced
this pull request
Feb 17, 2018
…of direct sourmap cache Merge pull request #4683 from obastemur:fix_m2free In case we load the same cached source file twice, ch won't track that and free the buffer twice. Originally reported by OSS-FUZZ OS#15921043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we load the same cached source file twice, ch won't track that and free the buffer twice.
Originally reported by OSS-FUZZ OS#15921043