Fix #2949: Class const name binding incorrectly marked as module export storage #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b3c5a8 to
f3179db
Compare
boingoing
approved these changes
Feb 9, 2018
Contributor
boingoing
left a comment
There was a problem hiding this comment.
Nice fix and good test coverage
| assert.areEqual(true, A2Inst.bindingModified(), 'Captured class name observes mutation'); | ||
| assert.throws(function () { A2Inst.attemptBindingChange(); }, TypeError, 'Delay exported class name captured in class is still const', "Assignment to const"); | ||
|
|
||
| export let B1 = class B1 { |
Contributor
There was a problem hiding this comment.
I'd like one more set of these if you don't mind where the let binding name is different from the class expression name. export let C1 = class NotC1 { for example.
Contributor
Author
There was a problem hiding this comment.
Done. Also fixed my conditional language which was inverted :)
…module export storage We were mistakenly marking both the class let and const decls as module export storage. This resulted in empty instantiated scopes and incorrect class behavior in some cases. The fix is not to mark the const binding as module export storage, as it is visible to the inside of the class only. Added some tests to verify the bindings of exported classes.
Contributor
|
Should there be a test of what is/is not observable from the site where the module is loaded? |
pleath
approved these changes
Feb 9, 2018
Contributor
pleath
left a comment
There was a problem hiding this comment.
Well, gee, that was easy. :)
chakrabot
pushed a commit
that referenced
this pull request
Feb 9, 2018
…marked as module export storage Merge pull request #4662 from tcare:classexport We were mistakenly marking both the class let and const decls as module export storage. This resulted in empty instantiated scopes and incorrect class behavior in some cases. The fix is not to mark the const binding as module export storage, as it is visible to the inside of the class only. Added some tests to verify the bindings of exported classes.
chakrabot
pushed a commit
that referenced
this pull request
Feb 9, 2018
…correctly marked as module export storage Merge pull request #4662 from tcare:classexport We were mistakenly marking both the class let and const decls as module export storage. This resulted in empty instantiated scopes and incorrect class behavior in some cases. The fix is not to mark the const binding as module export storage, as it is visible to the inside of the class only. Added some tests to verify the bindings of exported classes.
chakrabot
pushed a commit
that referenced
this pull request
Feb 9, 2018
…me binding incorrectly marked as module export storage Merge pull request #4662 from tcare:classexport We were mistakenly marking both the class let and const decls as module export storage. This resulted in empty instantiated scopes and incorrect class behavior in some cases. The fix is not to mark the const binding as module export storage, as it is visible to the inside of the class only. Added some tests to verify the bindings of exported classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mistakenly marking both the class let and const decls as module export storage. This resulted in empty instantiated scopes and incorrect class behavior in some cases.
The fix is not to mark the const binding as module export storage, as it is visible to the inside of the class only.
Added some tests to verify the bindings of exported classes.