Fixes for NPM test breaks. #4659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boingoing
approved these changes
Feb 8, 2018
Contributor
boingoing
left a comment
There was a problem hiding this comment.
Looks generally fine to me. If possible, I think I'd prefer to store the new.target value in a separate field so it's not confusing down the line but I can accept this as-is.
lib/Runtime/Debug/TTEvents.cpp
Outdated
|
|
||
| if (args.HasNewTarget()) | ||
| { | ||
| callEvt->ArgArray[args.Info.Count + 1] = static_cast<TTDVar>(args.GetNewTarget()); |
Contributor
There was a problem hiding this comment.
Would it make sense to allocate one more pointer in callEvt to handle the new.target (callEvt->newTargetPointer?) instead of tacking it on at the end? This is our data structure so we don't really need to sneakily add an extra arg here and it might be confusing why the argument count doesn't match.
Contributor
Author
There was a problem hiding this comment.
@mrkmarron can you have a look at the change I made for this?
Contributor
|
lgtm |
chakrabot
pushed a commit
that referenced
this pull request
Feb 9, 2018
Merge pull request #4659 from MSLaguana:fixTTD Some node-chakracore tests were throwing asserts when run with TTD.
chakrabot
pushed a commit
that referenced
this pull request
Feb 9, 2018
Merge pull request #4659 from MSLaguana:fixTTD Some node-chakracore tests were throwing asserts when run with TTD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some node-chakracore tests were throwing asserts when run with TTD.