Skip to content

asmjs/debugger/es7 enable disabled xplat tests #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chakrabot merged 1 commit into from
Feb 9, 2018
Merged

asmjs/debugger/es7 enable disabled xplat tests #4656

chakrabot merged 1 commit into from
Feb 9, 2018

Conversation

@obastemur
Copy link
Collaborator

@obastemur obastemur commented Feb 8, 2018

Fixes #3012
Fixes #2064

@obastemur obastemur requested a review from dilijev February 8, 2018 01:51
@dilijev
Copy link
Contributor

dilijev commented Feb 8, 2018 •
edited
Loading

The referenced issues are:

dilijev
dilijev approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@dilijev dilijev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chakrabot chakrabot merged commit 75a8fa0 into chakra-core:release/1.9 Feb 9, 2018
chakrabot pushed a commit that referenced this pull request Feb 9, 2018
@obastemur
[MERGE #4656 @obastemur] asmjs/debugger/es7 enable disabled xplat tests
b52d5c0 
Merge pull request #4656 from obastemur:enable_other_xplat_tests

Fixes #3012
Fixes #2064
chakrabot pushed a commit that referenced this pull request Feb 9, 2018
@obastemur
[1.9>master] [MERGE #4656 @obastemur] asmjs/debugger/es7 enable disab…
89e9b7c 
…led xplat tests

Merge pull request #4656 from obastemur:enable_other_xplat_tests

Fixes #3012
Fixes #2064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@dilijev dilijev dilijev approved these changes

@boingoing boingoing boingoing approved these changes

@agarwal-sandeep agarwal-sandeep agarwal-sandeep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@obastemur @dilijev @boingoing @agarwal-sandeep @chakrabot