OS#15659337: Try to allocate JIT code in PreReservedSegment even if CFG is not enabled #4647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeHolman
reviewed
Feb 7, 2018
lib/Backend/Func.cpp
Outdated
| #ifdef _CONTROL_FLOW_GUARD | ||
| return PHASE_FORCE1(Js::PreReservedHeapAllocPhase) || (!PHASE_OFF1(Js::PreReservedHeapAllocPhase) && | ||
| !IsJitInDebugMode() && GetThreadContextInfo()->IsCFGEnabled() | ||
| !IsJitInDebugMode() // && GetThreadContextInfo()->IsCFGEnabled() |
Contributor
There was a problem hiding this comment.
let's just remove the commented conditions
MikeHolman
approved these changes
Feb 7, 2018
…FG is not enabled This speeds up stack walking IsNativeAddress checks when CFG is not enabled.
79f849d to
d8b60d1
Compare
chakrabot
pushed a commit
that referenced
this pull request
Feb 7, 2018
…in PreReservedSegment even if CFG is not enabled Merge pull request #4647 from agarwal-sandeep:vso15659337 This speeds up stack walking IsNativeAddress checks when CFG is not enabled.
chakrabot
pushed a commit
that referenced
this pull request
Feb 8, 2018
… JIT code in PreReservedSegment even if CFG is not enabled Merge pull request #4647 from agarwal-sandeep:vso15659337 This speeds up stack walking IsNativeAddress checks when CFG is not enabled.
chakrabot
pushed a commit
that referenced
this pull request
Feb 8, 2018
…y to allocate JIT code in PreReservedSegment even if CFG is not enabled Merge pull request #4647 from agarwal-sandeep:vso15659337 This speeds up stack walking IsNativeAddress checks when CFG is not enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up stack walking IsNativeAddress checks when CFG is not enabled.