stack/error: disable it partially for xplat CI #4640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduces test run time to 1/3
Contributor
|
Is it worth commenting somewhere that interlocked_increment could improve such that we don't spend as much time waiting on locks? |
Collaborator
Author
that would be a bit vague? |
|
LGTM |
Collaborator
Author
|
@jianchun Thanks for the review |
chakrabot
pushed a commit
that referenced
this pull request
Feb 6, 2018
Merge pull request #4640 from obastemur:dis_stack_test_xp_ci_partially reduces test run time to 1/3 I've got bunch of CI failures due to this test is timing out (xplat). disabling a part of it helps to save it from whole run is going timeout. I did look into the details and saw `interlocked_increment` was playing a big role on the timeout. CH loses its' share from OS scheduler.. If CI machine is busy, it takes UNKNOWN amount of time for VM to get back the share needed.. well it loses again very soon because of the same reason. So, I won't add (todo, enable this) or open an issue to track this. Also, see the comments on the test file.
chakrabot
pushed a commit
that referenced
this pull request
Feb 6, 2018
…for xplat CI Merge pull request #4640 from obastemur:dis_stack_test_xp_ci_partially reduces test run time to 1/3 I've got bunch of CI failures due to this test is timing out (xplat). disabling a part of it helps to save it from whole run is going timeout. I did look into the details and saw `interlocked_increment` was playing a big role on the timeout. CH loses its' share from OS scheduler.. If CI machine is busy, it takes UNKNOWN amount of time for VM to get back the share needed.. well it loses again very soon because of the same reason. So, I won't add (todo, enable this) or open an issue to track this. Also, see the comments on the test file.
chakrabot
pushed a commit
that referenced
this pull request
Feb 6, 2018
…it partially for xplat CI Merge pull request #4640 from obastemur:dis_stack_test_xp_ci_partially reduces test run time to 1/3 I've got bunch of CI failures due to this test is timing out (xplat). disabling a part of it helps to save it from whole run is going timeout. I did look into the details and saw `interlocked_increment` was playing a big role on the timeout. CH loses its' share from OS scheduler.. If CI machine is busy, it takes UNKNOWN amount of time for VM to get back the share needed.. well it loses again very soon because of the same reason. So, I won't add (todo, enable this) or open an issue to track this. Also, see the comments on the test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduces test run time to 1/3
I've got bunch of CI failures due to this test is timing out (xplat). disabling a part of it helps to save it from whole run is going timeout.
I did look into the details and saw
interlocked_incrementwas playing a big role on the timeout. CH loses its' share from OS scheduler.. If CI machine is busy, it takes UNKNOWN amount of time for VM to get back the share needed.. well it loses again very soon because of the same reason.So, I won't add (todo, enable this) or open an issue to track this. Also, see the comments on the test file.