OS 15681335: Fix inspection of Promise state in debugger #4631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RecyclablePromiseObjectWalker::Get had a missing break when inspecting the state of a promise, causing an unresolved promise to show up as resolved in F12. Fixed the logic here.
agarwal-sandeep
approved these changes
Feb 1, 2018
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
… state in debugger Merge pull request #4631 from digitalinfinity:os_15681335_1.8 RecyclablePromiseObjectWalker::Get had a missing break when inspecting the state of a promise, causing an unresolved promise to show up as resolved in F12. Fixed the logic here.
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
…of Promise state in debugger Merge pull request #4631 from digitalinfinity:os_15681335_1.8 RecyclablePromiseObjectWalker::Get had a missing break when inspecting the state of a promise, causing an unresolved promise to show up as resolved in F12. Fixed the logic here.
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
…x inspection of Promise state in debugger Merge pull request #4631 from digitalinfinity:os_15681335_1.8 RecyclablePromiseObjectWalker::Get had a missing break when inspecting the state of a promise, causing an unresolved promise to show up as resolved in F12. Fixed the logic here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecyclablePromiseObjectWalker::Get had a missing break when inspecting the
state of a promise, causing an unresolved promise to show up as resolved in
F12. Fixed the logic here.