ARM64: fix in-proc jit memory leak #4620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm32 has special handling for xdata, but arm64 handles it the same way as amd64. see: https://github.com/Microsoft/ChakraCore/blob/c60cf515ac902af1c0c3d3d4e160c40d09b4659e/lib/Backend/NativeCodeGenerator.cpp#L1119
obastemur
reviewed
Jan 30, 2018
| #endif | ||
| XDataAllocator::Unregister(this->xdataInfo); | ||
| #if defined(_M_ARM32_OR_ARM64) | ||
| #if defined(_M_ARM) |
Collaborator
There was a problem hiding this comment.
Isn't _M_ARM is for all ARM ?
Collaborator
There was a problem hiding this comment.
It maybe should be defined(_M_ARM) && _M_ARM <= 7 ?
Contributor
Author
There was a problem hiding this comment.
_M_ARM is defined for 32bit arm only, which is why we have the define _M_ARM32_OR_ARM64
Collaborator
There was a problem hiding this comment.
I see. Curious; arm v8 has both 32 and 64 bits right? Is this xdata difference is 32 bit only or arm arch below 8 ?
Collaborator
There was a problem hiding this comment.
Same binary doesn't run in 64bit and 32 bit mode. On 64bit Windows\SysWOW64 contains 32bit binary.
chakrabot
pushed a commit
that referenced
this pull request
Jan 31, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jan 31, 2018
Merge pull request #4620 from sigatrev:arm64_inproc arm32 has special handling for xdata, but arm64 handles it the same way as amd64.
chakrabot
pushed a commit
that referenced
this pull request
Jan 31, 2018
… memory leak Merge pull request #4620 from sigatrev:arm64_inproc arm32 has special handling for xdata, but arm64 handles it the same way as amd64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arm32 has special handling for xdata, but arm64 handles it the same way as amd64. see: https://github.com/Microsoft/ChakraCore/blob/c60cf515ac902af1c0c3d3d4e160c40d09b4659e/lib/Backend/NativeCodeGenerator.cpp#L1119