Skip to content

fix issue unregistering function table #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chakrabot merged 2 commits into from
Jan 30, 2018
Merged

fix issue unregistering function table #4619

chakrabot merged 2 commits into from
Jan 30, 2018

Conversation

@leirocks
Copy link
Contributor

@leirocks leirocks commented Jan 30, 2018

  1. in between removing entry from SList and doing the unregistering, another thread might got the code address and doing registering. the fix is to make sure unregistering function table always happen before freeing the code address.
  2. remove the code for x86

@leirocks
fix issue unregistering function table
eaef3d1 
1. in between removing entry from SList and doing the unregistering, another thread might got the code address and doing registering. the fix is to make sure unregistering function table always happen before freeing the code address.
2. remove the code for x86
curtisman
curtisman approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@curtisman curtisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chakrabot chakrabot merged commit 274a06b into chakra-core:release/1.8 Jan 30, 2018
chakrabot pushed a commit that referenced this pull request Jan 30, 2018
@leirocks
[MERGE #4619 @leirocks] fix issue unregistering function table
fdf00b8 
Merge pull request #4619 from leirocks:xdata1

1. in between removing entry from SList and doing the unregistering, another thread might got the code address and doing registering. the fix is to make sure unregistering function table always happen before freeing the code address.
2. remove the code for x86
chakrabot pushed a commit that referenced this pull request Jan 30, 2018
@leirocks
[1.8>1.9] [MERGE #4619 @leirocks] fix issue unregistering function table
cc2aede 
Merge pull request #4619 from leirocks:xdata1

1. in between removing entry from SList and doing the unregistering, another thread might got the code address and doing registering. the fix is to make sure unregistering function table always happen before freeing the code address.
2. remove the code for x86
chakrabot pushed a commit that referenced this pull request Jan 30, 2018
@leirocks
[1.9>master] [1.8>1.9] [MERGE #4619 @leirocks] fix issue unregisterin…
10170c4 
…g function table

Merge pull request #4619 from leirocks:xdata1

1. in between removing entry from SList and doing the unregistering, another thread might got the code address and doing registering. the fix is to make sure unregistering function table always happen before freeing the code address.
2. remove the code for x86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeHolman MikeHolman Awaiting requested review from MikeHolman

1 more reviewer

@curtisman curtisman curtisman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leirocks @curtisman @chakrabot