OS#14568840: Remove 'this' binding for indirect eval #4618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a 'this' binding in the indirect eval leads to problems if there is a lambda capturing 'this' in the indirect eval. The lambda would try to load 'this' from a scope slot in the global scope of the indirect eval which asserts. Seems we can simplify the above by just removing the 'this' binding from the indirect eval. Then we'll simply load 'this' like an ordinary lambda at global scope would. Fixes: https://microsoft.visualstudio.com/web/wi.aspx?id=14568840
Contributor
|
Looks good. This is the way I'd originally hoped we could do it. |
pleath
approved these changes
Feb 3, 2018
chakrabot
pushed a commit
that referenced
this pull request
Feb 3, 2018
…ect eval Merge pull request #4618 from boingoing:RemoveThisBindingIndirectEval Having a 'this' binding in the indirect eval leads to problems if there is a lambda capturing 'this' in the indirect eval. The lambda would try to load 'this' from a scope slot in the global scope of the indirect eval which asserts. Seems we can simplify the above by just removing the 'this' binding from the indirect eval. Then we'll simply load 'this' like an ordinary lambda at global scope would. Fixes: https://microsoft.visualstudio.com/web/wi.aspx?id=14568840
chakrabot
pushed a commit
that referenced
this pull request
Feb 3, 2018
… for indirect eval Merge pull request #4618 from boingoing:RemoveThisBindingIndirectEval Having a 'this' binding in the indirect eval leads to problems if there is a lambda capturing 'this' in the indirect eval. The lambda would try to load 'this' from a scope slot in the global scope of the indirect eval which asserts. Seems we can simplify the above by just removing the 'this' binding from the indirect eval. Then we'll simply load 'this' like an ordinary lambda at global scope would. Fixes: https://microsoft.visualstudio.com/web/wi.aspx?id=14568840
chakrabot
pushed a commit
that referenced
this pull request
Feb 3, 2018
…this' binding for indirect eval Merge pull request #4618 from boingoing:RemoveThisBindingIndirectEval Having a 'this' binding in the indirect eval leads to problems if there is a lambda capturing 'this' in the indirect eval. The lambda would try to load 'this' from a scope slot in the global scope of the indirect eval which asserts. Seems we can simplify the above by just removing the 'this' binding from the indirect eval. Then we'll simply load 'this' like an ordinary lambda at global scope would. Fixes: https://microsoft.visualstudio.com/web/wi.aspx?id=14568840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a 'this' binding in the indirect eval leads to problems if there is a lambda capturing 'this' in the indirect eval. The lambda would try to load 'this' from a scope slot in the global scope of the indirect eval which asserts.
Seems we can simplify the above by just removing the 'this' binding from the indirect eval. Then we'll simply load 'this' like an ordinary lambda at global scope would.
Fixes:
https://microsoft.visualstudio.com/web/wi.aspx?id=14568840