Fix error messages on errors created through the JSRT #4614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
reviewed
Jan 30, 2018
lib/Jsrt/Jsrt.cpp
Outdated
| { | ||
| Js::JavascriptOperators::OP_SetProperty(newError, Js::PropertyIds::message, message, scriptContext); | ||
| Js::PropertyDescriptor desc; | ||
| desc.SetValue(message); |
Contributor
There was a problem hiding this comment.
For ease-of-viewing, I'd appreciate if this also explicitly set configurable and writable to true, to match the spec.
MSLaguana
approved these changes
Jan 30, 2018
kfarnung
approved these changes
Jan 30, 2018
Contributor
kfarnung
left a comment
There was a problem hiding this comment.
We should rebase against release/1.9
a0422ed to
f62d4d4
Compare
Contributor
Author
|
Updated the implementation a bit and rebased on 1.9 |
kfarnung
approved these changes
Jan 30, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jan 30, 2018
…h the JSRT Merge pull request #4614 from jackhorton:jsrt_error_message This will unblock the 01/14/18 node merge pump
chakrabot
pushed a commit
that referenced
this pull request
Jan 30, 2018
…reated through the JSRT Merge pull request #4614 from jackhorton:jsrt_error_message This will unblock the 01/14/18 node merge pump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will unblock the 01/14/18 node merge pump