OS#13976524: Force scanner to create pid for string constant trailing defer-parsed compact-body lambda #4612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… defer-parsed compact-body lambda Lambda with compact-body which is defer-parsed and which is trailed immediately by a string constant can cause the string constant to miss having a pid created. When we try to load the string constant table in `ByteCodeGenerator`, we'll hit an AV with this pid being nullptr. Fix by forcing the scanner to create a pid for this string constant - only for the single case of a string constant token immediately following the single-expression lambda body which is defer-parsed. Test case looks like this: ``` jtmchw => z '123' ``` Fixes: https://microsoft.visualstudio.com/web/wi.aspx?id=13976524
Contributor
Author
|
@dotnet-bot test Ubuntu shared_ubuntu_linux_debug please |
pleath
approved these changes
Feb 3, 2018
chakrabot
pushed a commit
that referenced
this pull request
Feb 3, 2018
… string constant trailing defer-parsed compact-body lambda Merge pull request #4612 from boingoing:13976524 Lambda with compact-body which is defer-parsed and which is trailed immediately by a string constant can cause the string constant to miss having a pid created. When we try to load the string constant table in `ByteCodeGenerator`, we'll hit an AV with this pid being nullptr. Fix by forcing the scanner to create a pid for this string constant - only for the single case of a string constant token immediately following the single-expression lambda body which is defer-parsed. Test case looks like this: ``` jtmchw => z '123' ``` Fixes: https://microsoft.visualstudio.com/web/wi.aspx?id=13976524
chakrabot
pushed a commit
that referenced
this pull request
Feb 3, 2018
…te pid for string constant trailing defer-parsed compact-body lambda Merge pull request #4612 from boingoing:13976524 Lambda with compact-body which is defer-parsed and which is trailed immediately by a string constant can cause the string constant to miss having a pid created. When we try to load the string constant table in `ByteCodeGenerator`, we'll hit an AV with this pid being nullptr. Fix by forcing the scanner to create a pid for this string constant - only for the single case of a string constant token immediately following the single-expression lambda body which is defer-parsed. Test case looks like this: ``` jtmchw => z '123' ``` Fixes: https://microsoft.visualstudio.com/web/wi.aspx?id=13976524
chakrabot
pushed a commit
that referenced
this pull request
Feb 3, 2018
…anner to create pid for string constant trailing defer-parsed compact-body lambda Merge pull request #4612 from boingoing:13976524 Lambda with compact-body which is defer-parsed and which is trailed immediately by a string constant can cause the string constant to miss having a pid created. When we try to load the string constant table in `ByteCodeGenerator`, we'll hit an AV with this pid being nullptr. Fix by forcing the scanner to create a pid for this string constant - only for the single case of a string constant token immediately following the single-expression lambda body which is defer-parsed. Test case looks like this: ``` jtmchw => z '123' ``` Fixes: https://microsoft.visualstudio.com/web/wi.aspx?id=13976524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambda with compact-body which is defer-parsed and which is trailed immediately by a string constant can cause the string constant to miss having a pid created. When we try to load the string constant table in
ByteCodeGenerator, we'll hit an AV with this pid being nullptr.Fix by forcing the scanner to create a pid for this string constant - only for the single case of a string constant token immediately following the single-expression lambda body which is defer-parsed.
Test case looks like this:
Fixes:
https://microsoft.visualstudio.com/web/wi.aspx?id=13976524