Skip to content

es6module: enable test3257 #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chakrabot merged 2 commits into from
Jan 25, 2018
Merged

es6module: enable test3257 #4600

chakrabot merged 2 commits into from
Jan 25, 2018

Conversation

@obastemur
Copy link
Collaborator

@obastemur obastemur commented Jan 24, 2018

Fixes #4575

@obastemur obastemur requested a review from boingoing January 24, 2018 23:17
@obastemur obastemur changed the base branch from master to release/1.8 January 24, 2018 23:17
boingoing
boingoing approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

MSLaguana
MSLaguana reviewed Jan 24, 2018
View reviewed changes
test/es6module/bug_issue_3257.js
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
//-------------------------------------------------------------------------------------------------------

WScript.RegisterModuleSource("mod0.js", `
Copy link
Contributor

@MSLaguana MSLaguana Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this isn't correctly registering as a module, since a test is failing on CI:

>Error in opening file 'D:\j\workspace\x86_test_prtest3d272688\test\es6module\mod0.js' : The system cannot find the file specified.

Copy link
Collaborator Author

@obastemur obastemur Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting this didn't show up with other test cases.

@chakrabot chakrabot merged commit 540fe28 into chakra-core:release/1.8 Jan 25, 2018
chakrabot pushed a commit that referenced this pull request Jan 25, 2018
@obastemur
[MERGE #4600 @obastemur] es6module: enable test3257
ac5bc4d 
Merge pull request #4600 from obastemur:enable_3257

Fixes #4575
@rhuanjl
Copy link
Collaborator

rhuanjl commented Jan 25, 2018

Good to see test re-enabled. Good work @obastemur

chakrabot pushed a commit that referenced this pull request Jan 26, 2018
@obastemur
[1.8>1.9] [MERGE #4600 @obastemur] es6module: enable test3257
483cea6 
Merge pull request #4600 from obastemur:enable_3257

Fixes #4575
chakrabot pushed a commit that referenced this pull request Jan 26, 2018
@obastemur
[1.9>master] [1.8>1.9] [MERGE #4600 @obastemur] es6module: enable tes…
d4a36fd 
…t3257

Merge pull request #4600 from obastemur:enable_3257

Fixes #4575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@MSLaguana MSLaguana MSLaguana left review comments

@sethbrenith sethbrenith sethbrenith approved these changes

@boingoing boingoing boingoing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@obastemur @rhuanjl @sethbrenith @boingoing @MSLaguana @chakrabot