osx: use clock_gettime when it's available #4593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent OSX distros have clock_gettime support. Use it when it's available (~3 times faster to what we do to replace that)
dilijev
approved these changes
Jan 23, 2018
| inline static double GetSystemTimeREAL() | ||
| { | ||
| #ifndef __APPLE__ | ||
| #ifdef HAVE_WORKING_CLOCK_GETTIME |
Contributor
There was a problem hiding this comment.
how does this macro get defined?
Collaborator
Author
There was a problem hiding this comment.
During pre-build by configure.cmake. It tests the feature on the system and then enables / disables for the build
Contributor
There was a problem hiding this comment.
It's part of the PAL cmake I think: https://github.com/Microsoft/ChakraCore/blob/97fdeb81f981c71bc3fc6263b310a810eb5a6374/pal/src/configure.cmake#L352
MSLaguana
approved these changes
Jan 23, 2018
Contributor
MSLaguana
left a comment
There was a problem hiding this comment.
LGTM, but I think this should target release/1.9 rather than 1.8
Collaborator
Author
|
It targets r1.8 due to timeouts on CI (slow running tests) |
Collaborator
Author
|
@dilijev @MSLaguana Thanks for the review! |
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
Merge pull request #4593 from obastemur:use_clock_gettime_osx Recent OSX distros have clock_gettime support. Use it when it's available (~3 times faster to what we do to replace that)
chakrabot
pushed a commit
that referenced
this pull request
Jan 24, 2018
…vailable Merge pull request #4593 from obastemur:use_clock_gettime_osx Recent OSX distros have clock_gettime support. Use it when it's available (~3 times faster to what we do to replace that)
chakrabot
pushed a commit
that referenced
this pull request
Jan 24, 2018
…e when it's available Merge pull request #4593 from obastemur:use_clock_gettime_osx Recent OSX distros have clock_gettime support. Use it when it's available (~3 times faster to what we do to replace that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent OSX distros have clock_gettime support. Use it when it's available (~3 times faster to what we do to replace that)