Add TTD record to the JsConvertValueToString fast path #4592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mrkmarron Does this seem like a viable approach? I know we had also discussed just skipping the fast path entirely when TTD is recording. |
Contributor
Author
|
@obastemur Any concerns about this approach? |
Collaborator
|
LGTM |
JsConvertValueToString can implicitly marshal values between script contexts. Even if there's no conversion occurring the result still needs to be recorded.
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
…alueToString fast path Merge pull request #4592 from kfarnung:ttdstrings JsConvertValueToString can implicitly marshal values between script contexts. Even if there's no conversion occurring the result still needs to be recorded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsConvertValueToString can implicitly marshal values between script
contexts. Even if there's no conversion occurring the result still
needs to be recorded.